Skip to main content

Browse the archive

Revision 31a51c70f74e23dc52f2033e552990a03f3166a9 authored by Mike Pennisi on 29 June 2018, 15:27:58 UTC, committed by Ms2ger on 02 July 2018, 14:31:05 UTC 
[fullscreen] Do not return value from cleanup fns
 
Today, the return value of functions provided to the global
`add_cleanup` function has no effect on the behavior of the test runner.
An upcoming feature addition to testharness.js will cause the return
value to influence test results [1].

Despite this, some existing tests have already been authored to return a
value: the result of `document.exitFullScreen`. Although this is
expected to be a Promise in conforming implementations, some browsers do
not yet implement this functionality.

To allow the new test harness feature to land without introducing
harness errors, refactor existing tests to omit a return value.

Additionally, use `Promise.prototype.catch` to avoid race conditions
resulting from unhandled Promise rejections (which trigger a harness
error in testharness.js today).

[1] https://github.com/web-platform-tests/wpt/issues/6075
1 parent 21369c1
Raw File
historical.html 
<!doctype html>
<title>Custom Elements v0 features</title>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<script>
test(() => {
  assert_false('registerElement' in document)
}, 'document.registerElement should not exist')

// These tests should pass as long as v0 isn't supported:
// v0: a 2nd string argument for createElement.
// v1: a ElementCreationOptions (dictionary) argument.
test(() => {
  try {
    const element = document.createElement('x', 'string')
    // If neither v0/v1 are supported, then there should be no is attribute.
    assert_false(element.hasAttribute('is'))
  } catch (e) {
    // If v1 is supported, then converting string to dictionary should throw.
    assert_throws(new TypeError, function() { throw e })
  }
}, 'document.createElement(localName, "string") should not work')

// createElementNS is analagous, but for the 3rd argument
test(() => {
  try {
    const element = document.createElementNS(null, 'x', 'string')
    // If neither v0/v1 are supported, then there should be no is attribute.
    assert_false(element.hasAttribute('is'))
  } catch (e) {
    // If v1 is supported, then converting string to dictionary should throw.
    assert_throws(new TypeError, function() { throw e })
  }
}, 'document.createElementNS(namespace, qualifiedName, "string") should not work')
</script>
back to top