Revision 324e955cc8091466f16bd6d7b7897a49872cca79 authored by Danny Grove on 08 January 2020, 12:16:21 UTC, committed by Pierre Boutillier on 13 January 2020, 18:12:54 UTC
The previous configuration of building with Docker used a lot of
'magic' and required a fair bit of traversal between the shell scripts
to understand what was happening and where. Most of it could be solved
by using Docker Multi-staged Builds but to not constantly break the
cache when just dealing with final artifacts I've split out the builder
Dockerfile from the main Dockerfile. I've also broken out the commands
run into individual make commands while trying to keep the original
shell script API mostly intact.

Running `./scripts/create_docker_image.sh` will work as it originally
did just with the modifications necessary to align the script to also
use the same underlying commands that are in make. I would have removed
the script completely and adjusted the build pipelines, but the Makefile
has an initial requirement of having `opam` installed which might not be
the case for all users or the base build system.

Othewise you can now just `make docker-image` but this will use the make
bindings. It might be a good idea in the future to make your own Docker
"building" image that can just use make within GitLabs CI system, but I
think that was out of scope of this change.
1 parent 318c9f2
History
File Mode Size
ci
create_genesis
docker
activate_protocol.sh -rwxr-xr-x 1.7 KB
alphanet.sh -rwxr-xr-x 24.3 KB
alphanet_version -rw-r--r-- 21 bytes
b58_prefix.py -rwxr-xr-x 1015 bytes
betanet.sh l--------- 11 bytes
check_opam_test.sh -rwxr-xr-x 873 bytes
create_docker_image.sh -rwxr-xr-x 746 bytes
gen_genesis.ml -rw-r--r-- 3.1 KB
install_build_deps.raw.sh -rwxr-xr-x 729 bytes
install_build_deps.sh -rwxr-xr-x 1.0 KB
localnet.sh l--------- 11 bytes
mainnet.sh l--------- 11 bytes
nginx.conf -rw-r--r-- 569 bytes
ocamldot.py -rwxr-xr-x 2.6 KB
opam-check.sh -rwxr-xr-x 1.1 KB
opam-pin.sh -rwxr-xr-x 588 bytes
opam-remove.sh -rwxr-xr-x 391 bytes
opam-test-all.sh -rwxr-xr-x 1.2 KB
opam-unpin.sh -rwxr-xr-x 233 bytes
opam-upgrade.sh -rwxr-xr-x 600 bytes
sandbox.json -rw-r--r-- 89 bytes
snapshot_alpha.sh -rwxr-xr-x 4.4 KB
update_hashes.sh -rwxr-xr-x 1.9 KB
update_integration_test.sh -rwxr-xr-x 1.2 KB
update_opam_repo.sh -rwxr-xr-x 3.9 KB
update_opam_test.sh -rwxr-xr-x 703 bytes
update_unit_test.sh -rwxr-xr-x 1.9 KB
version.sh -rw-r--r-- 464 bytes
yes-node.patch -rw-r--r-- 1.5 KB
yes-wallet.ml -rw-r--r-- 3.0 KB
zeronet.sh l--------- 11 bytes

back to top