Revision 32d9176e0831218c5c4d06c9c71a6f5123c9e204 authored by David Rajchenbach-Teller on 02 February 2016, 11:56:11 UTC, committed by David Rajchenbach-Teller on 02 February 2016, 11:56:11 UTC
While investigating bug 1243549, we encountered several instances of the following error message during each startup: ************************* A coding exception was thrown and uncaught in a Task. Full message: TypeError: this.Paths is null Full stack: Agent.wipe@resource:///modules/sessionstore/SessionWorker.js:296:7 worker.dispatch@resource:///modules/sessionstore/SessionWorker.js:21:24 anonymous/AbstractWorker.prototype.handleMessage@resource://gre/modules/workers/PromiseWorker.js:122:16 @resource:///modules/sessionstore/SessionWorker.js:30:41 ************************* These messages can be explained as follows: * If sanitization has failed during shutdown, it attempts again to sanitize during startup. This happens more often than it used to, because of 1/ startup bug fixes in bug 1089695; 2/ new shutdown bugs most likely also added by or around bug 1089695. * Sanitization during startup doesn't wait until Session Restore has properly started to sanitize the session. So sanitization of Session Restore file fails. This has probably always been the case, except we never noticed. * For some reason I do not understand, it attempts to sanitize several times. * I suspect that this can cause problems during startup, as sanitization and Session Restore race to use/remove the files of Session Restore. This patch makes sure that SessionFile.wipe() waits until initialization of SessionFile is complete before proceeding. --HG-- extra : source : a768b93e7f0f5e63d2b907d0e09d7c08247f9942 extra : intermediate-source : 932d8e4fcf3aa927c3fac8b4535d67e5b4638138
1 parent 8857c37
CLOBBER
# To trigger a clobber replace ALL of the textual description below,
# giving a bug number and a one line description of why a clobber is
# required. Modifying this file will make configure check that a
# clobber has been performed before the build can continue.
#
# MERGE NOTE: When merging two branches that require a CLOBBER, you should
# merge both CLOBBER descriptions, to ensure that users on
# both branches correctly see the clobber warning.
#
# O <-- Users coming from both parents need to Clobber
# / \
# O O
# | |
# O <-- Clobber O <-- Clobber
#
# Note: The description below will be part of the error message shown to users.
#
# Modifying this file will now automatically clobber the buildbot machines \o/
#
# Are you updating CLOBBER because you think it's needed for your WebIDL
# changes to stick? As of bug 928195, this shouldn't be necessary! Please
# don't change CLOBBER for WebIDL changes any more.
Merge day clobber
Computing file changes ...
