Revision 32d9176e0831218c5c4d06c9c71a6f5123c9e204 authored by David Rajchenbach-Teller on 02 February 2016, 11:56:11 UTC, committed by David Rajchenbach-Teller on 02 February 2016, 11:56:11 UTC
While investigating bug 1243549, we encountered several instances of the following error message during each startup:

*************************
A coding exception was thrown and uncaught in a Task.

Full message: TypeError: this.Paths is null
Full stack: Agent.wipe@resource:///modules/sessionstore/SessionWorker.js:296:7
worker.dispatch@resource:///modules/sessionstore/SessionWorker.js:21:24
anonymous/AbstractWorker.prototype.handleMessage@resource://gre/modules/workers/PromiseWorker.js:122:16
@resource:///modules/sessionstore/SessionWorker.js:30:41

*************************

These messages can be explained as follows:

* If sanitization has failed during shutdown, it attempts again to
  sanitize during startup. This happens more often than it used to,
  because of 1/ startup bug fixes in bug 1089695; 2/ new shutdown bugs
  most likely also added by or around bug 1089695.

* Sanitization during startup doesn't wait until Session Restore has
  properly started to sanitize the session. So sanitization of Session
  Restore file fails. This has probably always been the case, except
  we never noticed.

* For some reason I do not understand, it attempts to sanitize several
  times.

* I suspect that this can cause problems during startup, as
  sanitization and Session Restore race to use/remove the files of
  Session Restore.

This patch makes sure that SessionFile.wipe() waits until
initialization of SessionFile is complete before proceeding.

--HG--
extra : source : a768b93e7f0f5e63d2b907d0e09d7c08247f9942
extra : intermediate-source : 932d8e4fcf3aa927c3fac8b4535d67e5b4638138
1 parent 8857c37
History
File Mode Size
tests
moz.build -rw-r--r-- 1.7 KB
nsIWifiAccessPoint.idl -rw-r--r-- 1.1 KB
nsIWifiListener.idl -rw-r--r-- 881 bytes
nsIWifiMonitor.idl -rw-r--r-- 668 bytes
nsWifiAccessPoint.cpp -rw-r--r-- 2.2 KB
nsWifiAccessPoint.h -rw-r--r-- 2.0 KB
nsWifiMonitor.cpp -rw-r--r-- 7.0 KB
nsWifiMonitor.h -rw-r--r-- 2.4 KB
nsWifiMonitorGonk.cpp -rw-r--r-- 4.5 KB
nsWifiScannerDBus.cpp -rw-r--r-- 9.1 KB
nsWifiScannerDBus.h -rw-r--r-- 1.3 KB
nsWifiScannerFreeBSD.cpp -rw-r--r-- 4.6 KB
nsWifiScannerMac.cpp -rw-r--r-- 1.5 KB
nsWifiScannerSolaris.cpp -rw-r--r-- 3.8 KB
nsWifiScannerWin.cpp -rw-r--r-- 2.4 KB
osx_corewlan.mm -rw-r--r-- 3.1 KB
osx_wifi.h -rw-r--r-- 5.4 KB
win_wifiScanner.cpp -rw-r--r-- 6.3 KB
win_wifiScanner.h -rw-r--r-- 1.2 KB
win_wlanLibrary.cpp -rw-r--r-- 3.9 KB
win_wlanLibrary.h -rw-r--r-- 1.8 KB
win_xp_wifiScanner.cpp -rw-r--r-- 12.6 KB
win_xp_wifiScanner.h -rw-r--r-- 783 bytes

back to top