https://github.com/torvalds/linux
Revision 347d7e45bd09ce09cbc30d5cea9de377eb22f55c authored by Stevens, Nick on 01 July 2015, 16:07:41 UTC, committed by Guenter Roeck on 01 July 2015, 20:56:27 UTC
The mcp3021 scaling code is dividing the VDD (full-scale) value in millivolts by the A2D resolution to obtain the scaling factor. When VDD is 3300mV (the standard value) and the resolution is 12-bit (4096 divisions), the result is a scale factor of 3300/4096, which is always one. Effectively, the raw A2D reading is always being returned because no scaling is applied. This patch fixes the issue and simplifies the register-to-volts calculation, removing the unneeded "output_scale" struct member. Signed-off-by: Nick Stevens <Nick.Stevens@digi.com> Cc: stable@vger.kernel.org # v3.10+ [Guenter Roeck: Dropped unnecessary value check] Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 56172d8
Tip revision: 347d7e45bd09ce09cbc30d5cea9de377eb22f55c authored by Stevens, Nick on 01 July 2015, 16:07:41 UTC
hwmon: (mcp3021) Fix broken output scaling
hwmon: (mcp3021) Fix broken output scaling
Tip revision: 347d7e4
| File | Mode | Size |
|---|---|---|
| kasan | ||
| Kconfig | -rw-r--r-- | 21.3 KB |
| Kconfig.debug | -rw-r--r-- | 1.2 KB |
| Makefile | -rw-r--r-- | 2.6 KB |
| backing-dev.c | -rw-r--r-- | 25.2 KB |
| balloon_compaction.c | -rw-r--r-- | 6.8 KB |
| bootmem.c | -rw-r--r-- | 20.8 KB |
| cleancache.c | -rw-r--r-- | 9.9 KB |
| cma.c | -rw-r--r-- | 12.1 KB |
| cma.h | -rw-r--r-- | 508 bytes |
| cma_debug.c | -rw-r--r-- | 4.4 KB |
| compaction.c | -rw-r--r-- | 47.3 KB |
| debug-pagealloc.c | -rw-r--r-- | 2.6 KB |
| debug.c | -rw-r--r-- | 6.5 KB |
| dmapool.c | -rw-r--r-- | 13.7 KB |
| early_ioremap.c | -rw-r--r-- | 5.4 KB |
| fadvise.c | -rw-r--r-- | 3.7 KB |
| failslab.c | -rw-r--r-- | 1.3 KB |
| filemap.c | -rw-r--r-- | 70.7 KB |
| frontswap.c | -rw-r--r-- | 14.3 KB |
| gup.c | -rw-r--r-- | 39.0 KB |
| highmem.c | -rw-r--r-- | 11.8 KB |
| huge_memory.c | -rw-r--r-- | 79.1 KB |
| hugetlb.c | -rw-r--r-- | 107.0 KB |
| hugetlb_cgroup.c | -rw-r--r-- | 10.4 KB |
| hwpoison-inject.c | -rw-r--r-- | 3.3 KB |
| init-mm.c | -rw-r--r-- | 619 bytes |
| internal.h | -rw-r--r-- | 13.6 KB |
| interval_tree.c | -rw-r--r-- | 3.1 KB |
| kmemcheck.c | -rw-r--r-- | 2.9 KB |
| kmemleak-test.c | -rw-r--r-- | 3.2 KB |
| kmemleak.c | -rw-r--r-- | 54.8 KB |
| ksm.c | -rw-r--r-- | 63.3 KB |
| list_lru.c | -rw-r--r-- | 12.2 KB |
| maccess.c | -rw-r--r-- | 1.6 KB |
| madvise.c | -rw-r--r-- | 13.9 KB |
| memblock.c | -rw-r--r-- | 46.9 KB |
| memcontrol.c | -rw-r--r-- | 153.3 KB |
| memory-failure.c | -rw-r--r-- | 48.1 KB |
| memory.c | -rw-r--r-- | 103.6 KB |
| memory_hotplug.c | -rw-r--r-- | 51.2 KB |
| mempolicy.c | -rw-r--r-- | 70.6 KB |
| mempool.c | -rw-r--r-- | 13.9 KB |
| memtest.c | -rw-r--r-- | 3.0 KB |
| migrate.c | -rw-r--r-- | 46.7 KB |
| mincore.c | -rw-r--r-- | 6.6 KB |
| mlock.c | -rw-r--r-- | 19.5 KB |
| mm_init.c | -rw-r--r-- | 5.1 KB |
| mmap.c | -rw-r--r-- | 89.8 KB |
| mmu_context.c | -rw-r--r-- | 1.3 KB |
| mmu_notifier.c | -rw-r--r-- | 11.4 KB |
| mmzone.c | -rw-r--r-- | 2.3 KB |
| mprotect.c | -rw-r--r-- | 10.8 KB |
| mremap.c | -rw-r--r-- | 15.3 KB |
| msync.c | -rw-r--r-- | 2.6 KB |
| nobootmem.c | -rw-r--r-- | 11.0 KB |
| nommu.c | -rw-r--r-- | 52.0 KB |
| oom_kill.c | -rw-r--r-- | 20.6 KB |
| page-writeback.c | -rw-r--r-- | 83.1 KB |
| page_alloc.c | -rw-r--r-- | 184.3 KB |
| page_counter.c | -rw-r--r-- | 4.8 KB |
| page_ext.c | -rw-r--r-- | 10.3 KB |
| page_io.c | -rw-r--r-- | 9.4 KB |
| page_isolation.c | -rw-r--r-- | 8.7 KB |
| page_owner.c | -rw-r--r-- | 7.0 KB |
| pagewalk.c | -rw-r--r-- | 7.5 KB |
| percpu-km.c | -rw-r--r-- | 2.8 KB |
| percpu-vm.c | -rw-r--r-- | 10.0 KB |
| percpu.c | -rw-r--r-- | 66.1 KB |
| pgtable-generic.c | -rw-r--r-- | 5.7 KB |
| process_vm_access.c | -rw-r--r-- | 9.8 KB |
| quicklist.c | -rw-r--r-- | 2.4 KB |
| readahead.c | -rw-r--r-- | 15.6 KB |
| rmap.c | -rw-r--r-- | 43.8 KB |
| shmem.c | -rw-r--r-- | 89.3 KB |
| slab.c | -rw-r--r-- | 107.0 KB |
| slab.h | -rw-r--r-- | 10.5 KB |
| slab_common.c | -rw-r--r-- | 27.9 KB |
| slob.c | -rw-r--r-- | 15.7 KB |
| slub.c | -rw-r--r-- | 127.4 KB |
| sparse-vmemmap.c | -rw-r--r-- | 6.0 KB |
| sparse.c | -rw-r--r-- | 20.9 KB |
| swap.c | -rw-r--r-- | 32.0 KB |
| swap_cgroup.c | -rw-r--r-- | 4.6 KB |
| swap_state.c | -rw-r--r-- | 12.7 KB |
| swapfile.c | -rw-r--r-- | 77.0 KB |
| truncate.c | -rw-r--r-- | 23.7 KB |
| util.c | -rw-r--r-- | 10.9 KB |
| vmacache.c | -rw-r--r-- | 3.1 KB |
| vmalloc.c | -rw-r--r-- | 69.0 KB |
| vmpressure.c | -rw-r--r-- | 11.4 KB |
| vmscan.c | -rw-r--r-- | 110.3 KB |
| vmstat.c | -rw-r--r-- | 40.7 KB |
| workingset.c | -rw-r--r-- | 13.6 KB |
| zbud.c | -rw-r--r-- | 18.2 KB |
| zpool.c | -rw-r--r-- | 9.0 KB |
| zsmalloc.c | -rw-r--r-- | 45.4 KB |
| zswap.c | -rw-r--r-- | 24.8 KB |
Computing file changes ...
