Revision 34b759b4a22b0acb82423389a24699357798cf3c authored by Ilya Dryomov on 16 February 2016, 14:00:24 UTC, committed by Ilya Dryomov on 25 March 2016, 17:51:52 UTC
ceph_empty_snapc->num_snaps == 0 at all times. Passing such a snapc to
ceph_osdc_alloc_request() (possibly through ceph_osdc_new_request()) is
equivalent to passing NULL, as ceph_osdc_alloc_request() uses it only
for sizing the request message.
Further, in all four cases the subsequent ceph_osdc_build_request() is
passed NULL for snapc, meaning that 0 is encoded for seq and num_snaps
and making ceph_empty_snapc entirely useless. The two cases where it
actually mattered were removed in commits 860560904962 ("ceph: avoid
sending unnessesary FLUSHSNAP message") and 23078637e054 ("ceph: fix
queuing inode to mdsdir's snaprealm").
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Yan, Zheng <zyan@redhat.com>
1 parent ce43559
| File | Mode | Size |
|---|---|---|
| unittest-data | ||
| Kconfig | -rw-r--r-- | 2.4 KB |
| Makefile | -rw-r--r-- | 654 bytes |
| address.c | -rw-r--r-- | 25.1 KB |
| base.c | -rw-r--r-- | 62.2 KB |
| device.c | -rw-r--r-- | 7.1 KB |
| dynamic.c | -rw-r--r-- | 19.6 KB |
| fdt.c | -rw-r--r-- | 29.9 KB |
| fdt_address.c | -rw-r--r-- | 6.4 KB |
| irq.c | -rw-r--r-- | 20.8 KB |
| of_mdio.c | -rw-r--r-- | 11.9 KB |
| of_mtd.c | -rw-r--r-- | 2.8 KB |
| of_net.c | -rw-r--r-- | 2.4 KB |
| of_pci.c | -rw-r--r-- | 8.1 KB |
| of_pci_irq.c | -rw-r--r-- | 3.6 KB |
| of_private.h | -rw-r--r-- | 3.3 KB |
| of_reserved_mem.c | -rw-r--r-- | 8.7 KB |
| overlay.c | -rw-r--r-- | 13.3 KB |
| pdt.c | -rw-r--r-- | 5.7 KB |
| platform.c | -rw-r--r-- | 16.5 KB |
| resolver.c | -rw-r--r-- | 10.2 KB |
| unittest.c | -rw-r--r-- | 52.2 KB |
Computing file changes ...
