Revision 34b759b4a22b0acb82423389a24699357798cf3c authored by Ilya Dryomov on 16 February 2016, 14:00:24 UTC, committed by Ilya Dryomov on 25 March 2016, 17:51:52 UTC
ceph_empty_snapc->num_snaps == 0 at all times. Passing such a snapc to ceph_osdc_alloc_request() (possibly through ceph_osdc_new_request()) is equivalent to passing NULL, as ceph_osdc_alloc_request() uses it only for sizing the request message. Further, in all four cases the subsequent ceph_osdc_build_request() is passed NULL for snapc, meaning that 0 is encoded for seq and num_snaps and making ceph_empty_snapc entirely useless. The two cases where it actually mattered were removed in commits 860560904962 ("ceph: avoid sending unnessesary FLUSHSNAP message") and 23078637e054 ("ceph: fix queuing inode to mdsdir's snaprealm"). Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Reviewed-by: Yan, Zheng <zyan@redhat.com>
1 parent ce43559
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1.4 KB |
Makefile | -rw-r--r-- | 160 bytes |
checkpoint.c | -rw-r--r-- | 19.2 KB |
commit.c | -rw-r--r-- | 33.8 KB |
journal.c | -rw-r--r-- | 75.1 KB |
recovery.c | -rw-r--r-- | 21.5 KB |
revoke.c | -rw-r--r-- | 21.4 KB |
transaction.c | -rw-r--r-- | 78.4 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...