https://github.com/JuliaLang/julia
Revision 354c36742eb1c2c4c5bfe454d6d4fe975565de96 authored by Daniel Karrasch on 05 September 2023, 15:39:45 UTC, committed by GitHub on 05 September 2023, 15:39:45 UTC
Over the `AbstractMatrix` relaxation in v1.9, we missed a potential
indirection for wrapped sparse matrices. Instead, by default, a
`similar` copy is created (hence a sparse matrix) and then `lu!` with a
pivot argument is called. Such a method, however, does not exist in
SparseArrays.jl, which means that the `generic_lufact!` method gets
called, which is probably really bad performance-wise, due to heavy
reading and writing into the sparse matrix. This PR introduces one more
level at which SparseArrays.jl (and perhaps other external packages) may
interfere and redirect to their own implementations, in-place or
out-of-place.
1 parent 933ea1d
History
Tip revision: 354c36742eb1c2c4c5bfe454d6d4fe975565de96 authored by Daniel Karrasch on 05 September 2023, 15:39:45 UTC
Allow SparseArrays to catch `lu(::WrappedSparseMatrix)` (#51161)
Tip revision: 354c367
File Mode Size
.devcontainer
.github
base
cli
contrib
deps
doc
etc
src
stdlib
test
.buildkite-external-version -rw-r--r-- 5 bytes
.clang-format -rw-r--r-- 3.3 KB
.clangd -rw-r--r-- 114 bytes
.codecov.yml -rw-r--r-- 52 bytes
.git-blame-ignore-revs -rw-r--r-- 371 bytes
.gitattributes -rw-r--r-- 65 bytes
.gitignore -rw-r--r-- 523 bytes
.mailmap -rw-r--r-- 12.7 KB
CITATION.bib -rw-r--r-- 513 bytes
CITATION.cff -rw-r--r-- 940 bytes
CONTRIBUTING.md -rw-r--r-- 23.4 KB
HISTORY.md -rw-r--r-- 372.5 KB
LICENSE.md -rw-r--r-- 1.3 KB
Make.inc -rw-r--r-- 55.7 KB
Makefile -rw-r--r-- 30.5 KB
NEWS.md -rw-r--r-- 2.1 KB
README.md -rw-r--r-- 7.3 KB
THIRDPARTY.md -rw-r--r-- 3.8 KB
VERSION -rw-r--r-- 11 bytes
julia.spdx.json -rw-r--r-- 35.8 KB
pkgimage.mk -rw-r--r-- 6.3 KB
sysimage.mk -rw-r--r-- 4.3 KB

README.md

back to top