Skip to main content

Browse the archive

Revision 3657cf5f363fd64aeaf06432e62e3960800927b0 authored by Andrew Adams on 26 January 2024, 17:26:12 UTC, committed by GitHub on 26 January 2024, 17:26:12 UTC 
Fix bounds_of_nested_lanes (#8039)
 
* Fix bounds_of_nested_lanes

bounds_of_nested_lanes assumed that one layer of nested vectorization
could be removed at a time. When faced with the expression:

min(ramp(x8(a), x8(b), 5), x40(27))

It panicked, because on the left hand side it reduced the bounds to
x8(a) ... x8(a) + x8(b) * 4, and on the right hand side it reduced the
bounds to 27. It then attempted to take a min of mismatched types.

In general we can't assume that binary operators on nested vectors have
the same nesting structure on both sides, so I just rewrote it to reduce
directly to a scalar.

Fixes #8038
1 parent 4590a09
Raw File
Argument.cpp 
#include "Argument.h"

namespace Halide {

bool ArgumentEstimates::operator==(const ArgumentEstimates &rhs) const {
    if (buffer_estimates.size() != rhs.buffer_estimates.size()) {
        return false;
    }
    for (size_t i = 0; i < buffer_estimates.size(); ++i) {
        if (!buffer_estimates[i].min.same_as(rhs.buffer_estimates[i].min) ||
            !buffer_estimates[i].extent.same_as(rhs.buffer_estimates[i].extent)) {
            return false;
        }
    }
    return scalar_def.same_as(rhs.scalar_def) &&
           scalar_min.same_as(rhs.scalar_min) &&
           scalar_max.same_as(rhs.scalar_max) &&
           scalar_estimate.same_as(rhs.scalar_estimate);
}

Argument::Argument(const std::string &_name, Kind _kind, const Type &_type, int _dimensions, const ArgumentEstimates &argument_estimates)
    : name(_name), kind(_kind), dimensions((uint8_t)_dimensions), type(_type), argument_estimates(argument_estimates) {
    internal_assert(_dimensions >= 0 && _dimensions <= 255);
    user_assert(!(is_scalar() && dimensions != 0)) << "Scalar Arguments must specify dimensions of 0";
    user_assert(argument_estimates.buffer_estimates.empty() ||
                argument_estimates.buffer_estimates.size() == dimensions)
        << "buffer_estimates must match dimensionality for Argument " << name;
}

}  // namespace Halide
back to top