Skip to main content

Browse the archive

https://github.com/git/git
31 May 2024, 23:06:24 UTC
Revision 372ef954a15c321a1065bf7e764449ce7767277f authored by Shawn O. Pearce on 18 February 2007, 07:12:32 UTC, committed by Shawn O. Pearce on 18 February 2007, 07:12:32 UTC 
git-gui: Correct crash when saving options in blame mode.
 
Martin Waitz noticed that git-gui crashed while saving the user's
options out if the application was started in blame mode.  This
was caused by the do_save_config procedure invoking reshow_diff
incase the number of context lines was modified by the user.
Because we bypassed main window UI setup to enter blame mode we
did not set many of the globals which were accessed by reshow_diff,
and reading unset variables is an error in Tcl.

Aside from moving the globals to be set earlier, I also modified
reshow_diff to not invoke clear_diff if there is no path currently
in the diff viewer.  This way reshow_diff does not crash when in
blame mode due to the $ui_diff command not being defined.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
1 parent b90d479
History
Tip revision: 372ef954a15c321a1065bf7e764449ce7767277f authored by Shawn O. Pearce on 18 February 2007, 07:12:32 UTC
git-gui: Correct crash when saving options in blame mode.
Tip revision: 372ef95
File Mode Size
.gitignore -rw-r--r-- 36 bytes
GIT-VERSION-GEN -rwxr-xr-x 1.8 KB
Makefile -rw-r--r-- 1.3 KB
TODO -rw-r--r-- 1.6 KB
git-gui.sh -rwxr-xr-x 145.0 KB
back to top