https://github.com/torvalds/linux
Revision 3737df782c740b944912ed93420c57344b1cf864 authored by Andrea Righi on 30 August 2023, 15:58:20 UTC, committed by Luis Chamberlain on 01 November 2023, 20:07:08 UTC
Use a similar approach as commit a419beac4a07 ("module/decompress: use vmalloc() for zstd decompression workspace") and replace kmalloc() with vmalloc() also for the gzip module decompression workspace. In this case the workspace is represented by struct inflate_workspace that can be fairly large for kmalloc() and it can potentially lead to allocation errors on certain systems: $ pahole inflate_workspace struct inflate_workspace { struct inflate_state inflate_state; /* 0 9544 */ /* --- cacheline 149 boundary (9536 bytes) was 8 bytes ago --- */ unsigned char working_window[32768]; /* 9544 32768 */ /* size: 42312, cachelines: 662, members: 2 */ /* last cacheline: 8 bytes */ }; Considering that there is no need to use continuous physical memory, simply switch to vmalloc() to provide a more reliable in-kernel module decompression. Fixes: b1ae6dc41eaa ("module: add in-kernel support for decompressing") Signed-off-by: Andrea Righi <andrea.righi@canonical.com> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
1 parent 62eedac
Tip revision: 3737df782c740b944912ed93420c57344b1cf864 authored by Andrea Righi on 30 August 2023, 15:58:20 UTC
module/decompress: use vmalloc() for gzip decompression workspace
module/decompress: use vmalloc() for gzip decompression workspace
Tip revision: 3737df7
File | Mode | Size |
---|---|---|
6lowpan | ||
802 | ||
8021q | ||
9p | ||
appletalk | ||
atm | ||
ax25 | ||
batman-adv | ||
bluetooth | ||
bpf | ||
bpfilter | ||
bridge | ||
caif | ||
can | ||
ceph | ||
core | ||
dcb | ||
dccp | ||
devlink | ||
dns_resolver | ||
dsa | ||
ethernet | ||
ethtool | ||
handshake | ||
hsr | ||
ieee802154 | ||
ife | ||
ipv4 | ||
ipv6 | ||
iucv | ||
kcm | ||
key | ||
l2tp | ||
l3mdev | ||
lapb | ||
llc | ||
mac80211 | ||
mac802154 | ||
mctp | ||
mpls | ||
mptcp | ||
ncsi | ||
netfilter | ||
netlabel | ||
netlink | ||
netrom | ||
nfc | ||
nsh | ||
openvswitch | ||
packet | ||
phonet | ||
psample | ||
qrtr | ||
rds | ||
rfkill | ||
rose | ||
rxrpc | ||
sched | ||
sctp | ||
smc | ||
strparser | ||
sunrpc | ||
switchdev | ||
tipc | ||
tls | ||
unix | ||
vmw_vsock | ||
wireless | ||
x25 | ||
xdp | ||
xfrm | ||
Kconfig | -rw-r--r-- | 15.3 KB |
Kconfig.debug | -rw-r--r-- | 758 bytes |
Makefile | -rw-r--r-- | 2.4 KB |
compat.c | -rw-r--r-- | 14.2 KB |
devres.c | -rw-r--r-- | 2.2 KB |
socket.c | -rw-r--r-- | 89.8 KB |
sysctl_net.c | -rw-r--r-- | 4.6 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...