https://github.com/facebook/rocksdb
Revision 38201b35996c2979edcdfb27fc7cbd3156503a6e authored by sdong on 23 February 2016, 01:29:28 UTC, committed by sdong on 23 February 2016, 19:42:15 UTC
Summary: DBImpl::SyncWAL() releases db mutex before calling DBImpl::MarkLogsSynced(), while inside DBImpl::MarkLogsSynced() we assert there is none or one outstanding log file. However, a memtable switch can happen in between and causing two or outstanding logs there, failing the assert. The diff adds a unit test that repros the issue and fix the assert so that the unit test passes. Test Plan: Run the new tests. Reviewers: anthony, kolmike, yhchiang, IslamAbdelRahman, kradhakrishnan, andrewkr Reviewed By: andrewkr Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D54621
1 parent 2568985
Tip revision: 38201b35996c2979edcdfb27fc7cbd3156503a6e authored by sdong on 23 February 2016, 01:29:28 UTC
Fix assert failure when DBImpl::SyncWAL() conflicts with log rolling
Fix assert failure when DBImpl::SyncWAL() conflicts with log rolling
Tip revision: 38201b3
ROCKSDB_LITE.md
# RocksDBLite
RocksDBLite is a project focused on mobile use cases, which don't need a lot of fancy things we've built for server workloads and they are very sensitive to binary size. For that reason, we added a compile flag ROCKSDB_LITE that comments out a lot of the nonessential code and keeps the binary lean.
Some examples of the features disabled by ROCKSDB_LITE:
* compiled-in support for LDB tool
* No backupable DB
* No support for replication (which we provide in form of TrasactionalIterator)
* No advanced monitoring tools
* No special-purpose memtables that are highly optimized for specific use cases
* No Transactions
When adding a new big feature to RocksDB, please add ROCKSDB_LITE compile guard if:
* Nobody from mobile really needs your feature,
* Your feature is adding a lot of weight to the binary.
Don't add ROCKSDB_LITE compile guard if:
* It would introduce a lot of code complexity. Compile guards make code harder to read. It's a trade-off.
* Your feature is not adding a lot of weight.
If unsure, ask. :)
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...