Revision 3822d0670c9d4342794d73e0d0e615322b40438e authored by Rahul Lakkireddy on 04 June 2021, 11:18:18 UTC, committed by David S. Miller on 04 June 2021, 21:45:13 UTC
When configuring TC-MQPRIO offload, only turn off netdev carrier and
don't bring physical link down in hardware. Otherwise, when the
physical link is brought up again after configuration, it gets
re-trained and stalls ongoing traffic.
Also, when firmware is no longer accessible or crashed, avoid sending
FLOWC and waiting for reply that will never come.
Fix following hung_task_timeout_secs trace seen in these cases.
INFO: task tc:20807 blocked for more than 122 seconds.
Tainted: G S 5.13.0-rc3+ #122
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
task:tc state:D stack:14768 pid:20807 ppid: 19366 flags:0x00000000
Call Trace:
__schedule+0x27b/0x6a0
schedule+0x37/0xa0
schedule_preempt_disabled+0x5/0x10
__mutex_lock.isra.14+0x2a0/0x4a0
? netlink_lookup+0x120/0x1a0
? rtnl_fill_ifinfo+0x10f0/0x10f0
__netlink_dump_start+0x70/0x250
rtnetlink_rcv_msg+0x28b/0x380
? rtnl_fill_ifinfo+0x10f0/0x10f0
? rtnl_calcit.isra.42+0x120/0x120
netlink_rcv_skb+0x4b/0xf0
netlink_unicast+0x1a0/0x280
netlink_sendmsg+0x216/0x440
sock_sendmsg+0x56/0x60
__sys_sendto+0xe9/0x150
? handle_mm_fault+0x6d/0x1b0
? do_user_addr_fault+0x1c5/0x620
__x64_sys_sendto+0x1f/0x30
do_syscall_64+0x3c/0x80
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f7f73218321
RSP: 002b:00007ffd19626208 EFLAGS: 00000246 ORIG_RAX: 000000000000002c
RAX: ffffffffffffffda RBX: 000055b7c0a8b240 RCX: 00007f7f73218321
RDX: 0000000000000028 RSI: 00007ffd19626210 RDI: 0000000000000003
RBP: 000055b7c08680ff R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000055b7c085f5f6
R13: 000055b7c085f60a R14: 00007ffd19636470 R15: 00007ffd196262a0
Fixes: b1396c2bd675 ("cxgb4: parse and configure TC-MQPRIO offload")
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 944d671
| File | Mode | Size |
|---|---|---|
| .kunitconfig | -rw-r--r-- | 58 bytes |
| Kconfig | -rw-r--r-- | 4.0 KB |
| Makefile | -rw-r--r-- | 703 bytes |
| acl.c | -rw-r--r-- | 6.7 KB |
| acl.h | -rw-r--r-- | 1.6 KB |
| balloc.c | -rw-r--r-- | 26.9 KB |
| bitmap.c | -rw-r--r-- | 2.7 KB |
| block_validity.c | -rw-r--r-- | 9.3 KB |
| dir.c | -rw-r--r-- | 17.5 KB |
| ext4.h | -rw-r--r-- | 131.4 KB |
| ext4_extents.h | -rw-r--r-- | 8.4 KB |
| ext4_jbd2.c | -rw-r--r-- | 9.9 KB |
| ext4_jbd2.h | -rw-r--r-- | 16.9 KB |
| extents.c | -rw-r--r-- | 164.0 KB |
| extents_status.c | -rw-r--r-- | 60.3 KB |
| extents_status.h | -rw-r--r-- | 8.0 KB |
| fast_commit.c | -rw-r--r-- | 61.1 KB |
| fast_commit.h | -rw-r--r-- | 4.6 KB |
| file.c | -rw-r--r-- | 23.9 KB |
| fsmap.c | -rw-r--r-- | 19.8 KB |
| fsmap.h | -rw-r--r-- | 2.0 KB |
| fsync.c | -rw-r--r-- | 5.2 KB |
| hash.c | -rw-r--r-- | 7.3 KB |
| ialloc.c | -rw-r--r-- | 44.5 KB |
| indirect.c | -rw-r--r-- | 42.6 KB |
| inline.c | -rw-r--r-- | 48.4 KB |
| inode-test.c | -rw-r--r-- | 7.5 KB |
| inode.c | -rw-r--r-- | 178.2 KB |
| ioctl.c | -rw-r--r-- | 32.3 KB |
| mballoc.c | -rw-r--r-- | 180.4 KB |
| mballoc.h | -rw-r--r-- | 5.9 KB |
| migrate.c | -rw-r--r-- | 16.8 KB |
| mmp.c | -rw-r--r-- | 10.0 KB |
| move_extent.c | -rw-r--r-- | 20.8 KB |
| namei.c | -rw-r--r-- | 113.9 KB |
| page-io.c | -rw-r--r-- | 15.2 KB |
| readpage.c | -rw-r--r-- | 11.3 KB |
| resize.c | -rw-r--r-- | 60.6 KB |
| super.c | -rw-r--r-- | 192.1 KB |
| symlink.c | -rw-r--r-- | 1.7 KB |
| sysfs.c | -rw-r--r-- | 16.3 KB |
| truncate.h | -rw-r--r-- | 1.5 KB |
| verity.c | -rw-r--r-- | 10.7 KB |
| xattr.c | -rw-r--r-- | 82.1 KB |
| xattr.h | -rw-r--r-- | 7.2 KB |
| xattr_hurd.c | -rw-r--r-- | 1.3 KB |
| xattr_security.c | -rw-r--r-- | 1.6 KB |
| xattr_trusted.c | -rw-r--r-- | 1.2 KB |
| xattr_user.c | -rw-r--r-- | 1.3 KB |
Computing file changes ...
