Revision 3891a84ccdad249c426c3e036d4fb086c388b4ce authored by Pratyush Yadav on 14 March 2020, 21:38:36 UTC, committed by Pratyush Yadav on 17 March 2020, 13:18:54 UTC
Evaluating the script in the same namespace as the chord itself creates potential for variable name collision. And in that case the script would unknowingly use the chord's variables. For example, say the script has a variable called 'is_completed', which also exists in the chord's namespace. The script then calls 'eval' and sets 'is_completed' to 1 thinking it is setting its own variable, completely unaware of how the chord works behind the scenes. This leads to the chord never actually executing because it sees 'is_completed' as true and thinks it has already completed. Avoid the potential collision by creating a separate namespace for the script that is a child of the chord's namespace. Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
1 parent 8a8efbe
File | Mode | Size |
---|---|---|
lib | ||
macosx | ||
po | ||
windows | ||
.gitattributes | -rw-r--r-- | 194 bytes |
.gitignore | -rw-r--r-- | 97 bytes |
GIT-VERSION-GEN | -rwxr-xr-x | 1.8 KB |
Makefile | -rw-r--r-- | 11.5 KB |
README.md | -rw-r--r-- | 6.1 KB |
git-gui--askpass | -rwxr-xr-x | 1.3 KB |
git-gui.sh | -rwxr-xr-x | 103.3 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...