Skip to main content

Browse the archive

swh:1:snp:47f1e8bb459169b0feb652a9c3d9cbabd8526d4a
Revision 3891a84ccdad249c426c3e036d4fb086c388b4ce authored by Pratyush Yadav on 14 March 2020, 21:38:36 UTC, committed by Pratyush Yadav on 17 March 2020, 13:18:54 UTC 
git-gui: create a new namespace for chord script evaluation
 
Evaluating the script in the same namespace as the chord itself creates
potential for variable name collision. And in that case the script would
unknowingly use the chord's variables.

For example, say the script has a variable called 'is_completed', which
also exists in the chord's namespace. The script then calls 'eval' and
sets 'is_completed' to 1 thinking it is setting its own variable,
completely unaware of how the chord works behind the scenes. This leads
to the chord never actually executing because it sees 'is_completed' as
true and thinks it has already completed.

Avoid the potential collision by creating a separate namespace for the
script that is a child of the chord's namespace.

Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
1 parent 8a8efbe
History
Tip revision: 84d06cdc06389ae7c462434cb7b1db0980f63860 authored by Junio C Hamano on 26 March 2021, 21:59:47 UTC
Sync with v2.31.1
Tip revision: 84d06cd
File Mode Size
lib
macosx
po
windows
.gitattributes -rw-r--r-- 194 bytes
.gitignore -rw-r--r-- 97 bytes
GIT-VERSION-GEN -rwxr-xr-x 1.8 KB
Makefile -rw-r--r-- 11.5 KB
README.md -rw-r--r-- 6.1 KB
git-gui--askpass -rwxr-xr-x 1.3 KB
git-gui.sh -rwxr-xr-x 103.3 KB

README.md

back to top