Revision 38d78e587d4960d0db94add518d27ee74bad2301 authored by Vladimir Davydov on 22 March 2013, 22:04:51 UTC, committed by Linus Torvalds on 22 March 2013, 23:41:21 UTC
mnt_drop_write() must be called only if mnt_want_write() succeeded, otherwise the mnt_writers counter will diverge. mnt_writers counters are used to check if remounting FS as read-only is OK, so after an extra mnt_drop_write() call, it would be impossible to remount mqueue FS as read-only. Besides, on umount a warning would be printed like this one: ===================================== [ BUG: bad unlock balance detected! ] 3.9.0-rc3 #5 Not tainted ------------------------------------- a.out/12486 is trying to release lock (sb_writers) at: mnt_drop_write+0x1f/0x30 but there are no more locks to release! Signed-off-by: Vladimir Davydov <vdavydov@parallels.com> Cc: Doug Ledford <dledford@redhat.com> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Cc: "Eric W. Biederman" <ebiederm@xmission.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent ca4b3f3
t3c_psram-1.1.0.bin.ihex
:10000000FFFFFFF4000000040000000100000001F9
:1000100000010100FFFFFFF40000000400000001E8
:100020000000000100000000FFFFFFF400000004DA
:10003000000000010000000100000000FFFFFFF4CD
:1000400000000004000000010000000100000000AA
:10005000FFFFFFF4000000040000000100000001A9
:1000600000000000FFFFFFF400000004000000019A
:100070000000000100000000FFFFFFF4000000048A
:10008000000000010000000100000000FFFFFFF47D
:10009000000000040000000100000001000000005A
:1000A000FFFFFFF400000004000000010000000159
:1000B00000000000FFFFFFF400000004000000014A
:1000C0000000000100000000FFFFFFF4000000043A
:1000D000000000010000000100000000FFFFFFF42D
:1000E000000000040000000100000001000000000A
:1000F000FFFFFFF400000004000000010000000109
:1001000000000000FFFFFFF40000000400000001F9
:100110000000000100000000FFFFFFF3D03403E205
:1001200080262A410000000100000000FFFFFFF8C8
:10013000007000000000000000000080C604000005
:10014000FFFFFFF4000000040000000100000001B8
:1001500000000000FFFFFFF40000000400000001A9
:100160000000000100000000FFFFFFF40000000499
:10017000000000010000000100000000FFFFFFF48C
:100180000000000400000001000000010000000069
:10019000FFFFFFF400000004000000010000000168
:1001A00000000000FFFFFFF4000000040000000159
:1001B0000000000100000000FFFFFFFBD03403E25D
:1001C000802829210000000100000000FFFFFFF847
:1001D0000600023701C5C00213940480C6057000F2
:1001E000FFFFFFF88200020637030801000000014C
:1001F00000000000FFFFFFF400000004000000000A
:10020000208000808DF40000FFFFFFF40000000458
:10021000000000010000000100000000FFFFFFF4EB
:1002200000000004000000010000000100000000C8
:10023000FFFFFFF4000000040000000100000001C7
:1002400000000000FFFFFFF40000000400000001B8
:100250000000000100000000FFFFFFF9C4310000B2
:1002600000282C810000000100000000FFFFFFF0CB
:100270004E70021D00C5C00200000000C118000041
:10028000FFFFFFF400000004000000010000000177
:1002900000000000FFFFFFF4000000040000000168
:1002A0000000000100000000FFFFFFF40000000458
:1002B000000000010000000100000000FFFFFFF44B
:1002C0000000000400000001000000010000000028
:1002D000FFFFFFF400000004000000010000000127
:1002E00000000000FFFFFFF4000000040000000118
:1002F0000000000100000000FFFFFFF1C00003E666
:10030000802828210000000100000000FFFFFFF40A
:1003100000000004000000021394040000017000BB
:10032000FFFFFFF4000000040000000100000001D6
:1003300000000000FFFFFFF40000000400000001C7
:100340000000000100000000FFFFFFF400000004B7
:10035000000000010000000100000000FFFFFFF4AA
:100360000000000400000001000000010000000087
:10037000FFFFFFF400000004000000010000000186
:1003800000000000FFFFFFF4000000040000000177
:100390000000000100000000FFFFFFFA103400041D
:1003A000000001010000000100000000FFFFFFF05D
:1003B0006000000620030802700000F080259A907B
:1003C000FFFFFFF400000004000000010000000136
:1003D00000000000FFFFFFF4000000040000000127
:1003E0000000000100000000FFFFFFF40000000417
:1003F000000000010000000100000000FFFFFFF40A
:1004000000000004000000010000000100000000E6
:10041000FFFFFFF9C83102020A000242000000811A
:1004200080000000FFFFFFF1C83103C20A962A4294
:100430000000008180000000FFFFFFF00431000495
:10044000000004010000000100000000FFFFFFF8B1
:1004500020B000040000000013940400C1197000D3
:10046000FFFFFFF400000004000000020000000095
:1004700000001000FFFFFFF4000000040000000176
:100480000000000100000000FFFFFFF40000000476
:10049000000000010000000100000000FFFFFFF469
:1004A0000000000400000001000000010000000046
:1004B000FFFFFFF80000000000004000680C200172
:1004C00000001090FFFFFFF9C031C3E600266A422A
:1004D0000000000000001000FFFFFFF210F4000415
:1004E000000002410000000100000000FFFFFFF0DB
:1004F0006050080400000002700C20F180259A90E2
:10050000FFFFFFF8060000040100400200000000A9
:1005100000001000FFFFFFF40000000400000002D4
:10052000288C108085C01000FFFFFFF4000000043D
:10053000000000010000000100000000FFFFFFF4C8
:1005400000000004000000010000000100000000A5
:10055000FFFFFFF4000000040000000100000001A4
:1005600000000000FFFFFFF4000000040000000195
:100570000000000100000000FFFFFFF04E0000003F
:10058000000000010000000100000000FFFFFFF973
:10059000C00002DA00061A42000000839035C00055
:1005A000FFFFFFF400000004000000010000000154
:1005B00000000000FFFFFFF4000000040000000145
:1005C0000000000100000000FFFFFFF40000000435
:1005D000000000010000000100000000FFFFFFF428
:1005E0000000000400000001000000010000000005
:1005F000FFFFFFF400000004000000010000000104
:1006000000000000FFFFFFF9CA31C3C60A966A4125
:100610000000000100000000FFFFFFF84E501439F9
:100620001CC5C0010000000100000000FFFFFFF03A
:100630000000000000000002288C108085C010001F
:10064000FFFFFFF4000000040000000100000001B3
:1006500000000000FFFFFFF40000000400000001A4
:100660000000000100000000FFFFFFF40000000494
:10067000000000010000000100000000FFFFFFF487
:100680000000000400000001000000010000000064
:10069000FFFFFFF400000004000000010000000163
:1006A00000000000FFFFFFF3CA3323D60E966A4115
:1006B0000000000100000000FFFFFFF8000004063A
:1006C00020D002410000000100000000FFFFFFF801
:1006D00000D0000000000000000000839031C00046
:1006E000FFFFFFF400000004000000010000000113
:1006F00000000000FFFFFFF4000000040000000104
:100700000000000100000000FFFFFFF400000004F3
:10071000000000010000000100000000FFFFFFF4E6
:1007200000000004000000010000000100000000C3
:10073000FFFFFFF4000000040000000100000001C2
:1007400000000000FFFFFFFBCA33E3D20E966A41B0
:100750000000000100000000FFFFFFF000501A1031
:10076000003002410000000100000000FFFFFFF028
:100770000000020220030800700000F990118A9026
:10078000FFFFFFF400000004000000010000000172
:1007900000000000FFFFFFF4000000040000000163
:1007A0000000000100000000FFFFFFF40000000453
:1007B000000000010000000100000000FFFFFFF446
:1007C0000000000400000001000000010000000023
:1007D000FFFFFFF400000004000000010000000122
:1007E00000000000FFFFFFF4000000040000000113
:1007F0000000000100000000FFFFFFF1C0501BA23D
:1008000000D202410000000100000000FFFFFFF8DD
:100810004000020300100002700000E890344A908B
:10082000FFFFFFF4000000040000000100000001D1
:1008300000000000FFFFFFF40000000400000001C2
:100840000000000100000000FFFFFFF400000004B2
:10085000000000010000000100000000FFFFFFF4A5
:100860000000000400000001000000010000000082
:10087000FFFFFFF400000004000000010000000181
:1008800000000000FFFFFFF4000000040000000172
:100890000000000100000000FFFFFFFA10F4020852
:1008A00000C002410000000100000000FFFFFFF057
:1008B0000000000000000002728CC8D993891090DB
:1008C000FFFFFFF082900000030000010000000124
:1008D00000000000FFFFFFF4000000040000000122
:1008E0000000000100000000FFFFFFF40000000412
:1008F000000000010000000100000000FFFFFFF405
:1009000000000004000000010000000100000000E1
:10091000FFFFFFF4000000040000000100000001E0
:1009200000000000FFFFFFF40000000400000001D1
:100930000000000100000000FFFFFFF000000000C9
:10094000000000010000000100000000FFFFFFF2B6
:1009500000000320002612410000000100000000FA
:10096000FFFFFFF040000203101000010000000133
:1009700000000000FFFFFFF4000000040000000181
:100980000000000100000000FFFFFFF40000000471
:10099000000000010000000100000000FFFFFFF464
:1009A0000000000400000001000000010000000041
:1009B000FFFFFFF400000004000000010000000140
:1009C00000000000FFFFFFF4000000040000000131
:1009D0000000000100000000FFFFFFF9D03403E237
:1009E00080262A410000000100000000FFFFFFF206
:1009F0000834023000C005010000000100000000C2
:040A000070EAA741B0
:00000001FF
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...