Revision 38d78e587d4960d0db94add518d27ee74bad2301 authored by Vladimir Davydov on 22 March 2013, 22:04:51 UTC, committed by Linus Torvalds on 22 March 2013, 23:41:21 UTC
mnt_drop_write() must be called only if mnt_want_write() succeeded, otherwise the mnt_writers counter will diverge. mnt_writers counters are used to check if remounting FS as read-only is OK, so after an extra mnt_drop_write() call, it would be impossible to remount mqueue FS as read-only. Besides, on umount a warning would be printed like this one: ===================================== [ BUG: bad unlock balance detected! ] 3.9.0-rc3 #5 Not tainted ------------------------------------- a.out/12486 is trying to release lock (sb_writers) at: mnt_drop_write+0x1f/0x30 but there are no more locks to release! Signed-off-by: Vladimir Davydov <vdavydov@parallels.com> Cc: Doug Ledford <dledford@redhat.com> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Cc: "Eric W. Biederman" <ebiederm@xmission.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent ca4b3f3
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 3.3 KB |
| Makefile | -rw-r--r-- | 1.1 KB |
| README | -rw-r--r-- | 7.9 KB |
| acl.h | -rw-r--r-- | 1.8 KB |
| bitmap.c | -rw-r--r-- | 39.2 KB |
| dir.c | -rw-r--r-- | 9.0 KB |
| do_balan.c | -rw-r--r-- | 57.0 KB |
| file.c | -rw-r--r-- | 10.4 KB |
| fix_node.c | -rw-r--r-- | 77.2 KB |
| hashes.c | -rw-r--r-- | 3.6 KB |
| ibalance.c | -rw-r--r-- | 35.2 KB |
| inode.c | -rw-r--r-- | 92.4 KB |
| ioctl.c | -rw-r--r-- | 5.4 KB |
| item_ops.c | -rw-r--r-- | 18.7 KB |
| journal.c | -rw-r--r-- | 121.4 KB |
| lbalance.c | -rw-r--r-- | 41.4 KB |
| lock.c | -rw-r--r-- | 2.6 KB |
| namei.c | -rw-r--r-- | 44.1 KB |
| objectid.c | -rw-r--r-- | 6.8 KB |
| prints.c | -rw-r--r-- | 20.7 KB |
| procfs.c | -rw-r--r-- | 14.6 KB |
| reiserfs.h | -rw-r--r-- | 116.7 KB |
| resize.c | -rw-r--r-- | 6.1 KB |
| stree.c | -rw-r--r-- | 64.4 KB |
| super.c | -rw-r--r-- | 67.5 KB |
| tail_conversion.c | -rw-r--r-- | 9.1 KB |
| xattr.c | -rw-r--r-- | 25.8 KB |
| xattr.h | -rw-r--r-- | 4.0 KB |
| xattr_acl.c | -rw-r--r-- | 12.5 KB |
| xattr_security.c | -rw-r--r-- | 2.9 KB |
| xattr_trusted.c | -rw-r--r-- | 1.4 KB |
| xattr_user.c | -rw-r--r-- | 1.3 KB |
Computing file changes ...
