Revision 3aa0ce825ade0cf5506e32ccf51d01fc8d22a9cf authored by Linus Torvalds on 14 October 2010, 21:32:06 UTC, committed by Linus Torvalds on 14 October 2010, 21:32:06 UTC
Tony Luck reports that the addition of the access_ok() check in commit 0eead9ab41da ("Don't dump task struct in a.out core-dumps") broke the ia64 compile due to missing the necessary header file includes. Rather than add yet another include (<asm/unistd.h>) to make everything happy, just uninline the silly core dump helper functions and move the bodies to fs/exec.c where they make a lot more sense. dump_seek() in particular was too big to be an inline function anyway, and none of them are in any way performance-critical. And we really don't need to mess up our include file headers more than they already are. Reported-and-tested-by: Tony Luck <tony.luck@gmail.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent ae42d8d
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 898 bytes |
Makefile | -rw-r--r-- | 416 bytes |
afs.h | -rw-r--r-- | 6.0 KB |
afs_cm.h | -rw-r--r-- | 1.2 KB |
afs_fs.h | -rw-r--r-- | 2.3 KB |
afs_vl.h | -rw-r--r-- | 3.6 KB |
cache.c | -rw-r--r-- | 10.8 KB |
callback.c | -rw-r--r-- | 11.4 KB |
cell.c | -rw-r--r-- | 10.3 KB |
cmservice.c | -rw-r--r-- | 13.2 KB |
dir.c | -rw-r--r-- | 27.1 KB |
file.c | -rw-r--r-- | 8.6 KB |
flock.c | -rw-r--r-- | 15.8 KB |
fsclient.c | -rw-r--r-- | 44.1 KB |
inode.c | -rw-r--r-- | 12.1 KB |
internal.h | -rw-r--r-- | 30.9 KB |
main.c | -rw-r--r-- | 4.2 KB |
misc.c | -rw-r--r-- | 2.3 KB |
mntpt.c | -rw-r--r-- | 7.5 KB |
netdevices.c | -rw-r--r-- | 1.5 KB |
proc.c | -rw-r--r-- | 17.0 KB |
rxrpc.c | -rw-r--r-- | 20.1 KB |
security.c | -rw-r--r-- | 8.9 KB |
server.c | -rw-r--r-- | 7.9 KB |
super.c | -rw-r--r-- | 12.3 KB |
vlclient.c | -rw-r--r-- | 5.4 KB |
vlocation.c | -rw-r--r-- | 17.7 KB |
vnode.c | -rw-r--r-- | 24.1 KB |
volume.c | -rw-r--r-- | 9.9 KB |
write.c | -rw-r--r-- | 18.4 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...