Revision 3aa0ce825ade0cf5506e32ccf51d01fc8d22a9cf authored by Linus Torvalds on 14 October 2010, 21:32:06 UTC, committed by Linus Torvalds on 14 October 2010, 21:32:06 UTC
Tony Luck reports that the addition of the access_ok() check in commit
0eead9ab41da ("Don't dump task struct in a.out core-dumps") broke the
ia64 compile due to missing the necessary header file includes.

Rather than add yet another include (<asm/unistd.h>) to make everything
happy, just uninline the silly core dump helper functions and move the
bodies to fs/exec.c where they make a lot more sense.

dump_seek() in particular was too big to be an inline function anyway,
and none of them are in any way performance-critical.  And we really
don't need to mess up our include file headers more than they already
are.

Reported-and-tested-by: Tony Luck <tony.luck@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent ae42d8d
History
File Mode Size
Kconfig -rw-r--r-- 1.7 KB
Makefile -rw-r--r-- 380 bytes
acl.c -rw-r--r-- 9.6 KB
acl.h -rw-r--r-- 1.5 KB
balloc.c -rw-r--r-- 44.9 KB
dir.c -rw-r--r-- 17.5 KB
ext2.h -rw-r--r-- 6.1 KB
file.c -rw-r--r-- 2.7 KB
ialloc.c -rw-r--r-- 18.2 KB
inode.c -rw-r--r-- 44.7 KB
ioctl.c -rw-r--r-- 4.3 KB
namei.c -rw-r--r-- 9.7 KB
super.c -rw-r--r-- 40.6 KB
symlink.c -rw-r--r-- 1.3 KB
xattr.c -rw-r--r-- 28.2 KB
xattr.h -rw-r--r-- 3.4 KB
xattr_security.c -rw-r--r-- 1.8 KB
xattr_trusted.c -rw-r--r-- 1.5 KB
xattr_user.c -rw-r--r-- 1.6 KB
xip.c -rw-r--r-- 2.0 KB
xip.h -rw-r--r-- 759 bytes

back to top