Revision 3aa0ce825ade0cf5506e32ccf51d01fc8d22a9cf authored by Linus Torvalds on 14 October 2010, 21:32:06 UTC, committed by Linus Torvalds on 14 October 2010, 21:32:06 UTC
Tony Luck reports that the addition of the access_ok() check in commit
0eead9ab41da ("Don't dump task struct in a.out core-dumps") broke the
ia64 compile due to missing the necessary header file includes.

Rather than add yet another include (<asm/unistd.h>) to make everything
happy, just uninline the silly core dump helper functions and move the
bodies to fs/exec.c where they make a lot more sense.

dump_seek() in particular was too big to be an inline function anyway,
and none of them are in any way performance-critical.  And we really
don't need to mess up our include file headers more than they already
are.

Reported-and-tested-by: Tony Luck <tony.luck@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent ae42d8d
History
File Mode Size
Kconfig -rw-r--r-- 5.7 KB
LICENCE -rw-r--r-- 1.4 KB
Makefile -rw-r--r-- 751 bytes
README.Locking -rw-r--r-- 7.0 KB
TODO -rw-r--r-- 1.9 KB
acl.c -rw-r--r-- 9.5 KB
acl.h -rw-r--r-- 1022 bytes
background.c -rw-r--r-- 4.4 KB
build.c -rw-r--r-- 10.9 KB
compr.c -rw-r--r-- 10.2 KB
compr.h -rw-r--r-- 3.0 KB
compr_lzo.c -rw-r--r-- 2.3 KB
compr_rtime.c -rw-r--r-- 2.9 KB
compr_rubin.c -rw-r--r-- 8.8 KB
compr_zlib.c -rw-r--r-- 5.8 KB
debug.c -rw-r--r-- 25.6 KB
debug.h -rw-r--r-- 8.4 KB
dir.c -rw-r--r-- 23.0 KB
erase.c -rw-r--r-- 14.5 KB
file.c -rw-r--r-- 9.2 KB
fs.c -rw-r--r-- 19.3 KB
gc.c -rw-r--r-- 43.9 KB
ioctl.c -rw-r--r-- 557 bytes
jffs2_fs_i.h -rw-r--r-- 1.6 KB
jffs2_fs_sb.h -rw-r--r-- 5.1 KB
malloc.c -rw-r--r-- 7.4 KB
nodelist.c -rw-r--r-- 21.7 KB
nodelist.h -rw-r--r-- 17.7 KB
nodemgmt.c -rw-r--r-- 27.7 KB
os-linux.h -rw-r--r-- 7.5 KB
read.c -rw-r--r-- 6.9 KB
readinode.c -rw-r--r-- 43.3 KB
scan.c -rw-r--r-- 35.5 KB
security.c -rw-r--r-- 2.1 KB
summary.c -rw-r--r-- 23.5 KB
summary.h -rw-r--r-- 6.3 KB
super.c -rw-r--r-- 7.7 KB
symlink.c -rw-r--r-- 1.8 KB
wbuf.c -rw-r--r-- 36.5 KB
write.c -rw-r--r-- 21.3 KB
writev.c -rw-r--r-- 1.8 KB
xattr.c -rw-r--r-- 37.7 KB
xattr.h -rw-r--r-- 4.1 KB
xattr_trusted.c -rw-r--r-- 1.4 KB
xattr_user.c -rw-r--r-- 1.4 KB

README.Locking

back to top