Revision 3aa0ce825ade0cf5506e32ccf51d01fc8d22a9cf authored by Linus Torvalds on 14 October 2010, 21:32:06 UTC, committed by Linus Torvalds on 14 October 2010, 21:32:06 UTC
Tony Luck reports that the addition of the access_ok() check in commit
0eead9ab41da ("Don't dump task struct in a.out core-dumps") broke the
ia64 compile due to missing the necessary header file includes.

Rather than add yet another include (<asm/unistd.h>) to make everything
happy, just uninline the silly core dump helper functions and move the
bodies to fs/exec.c where they make a lot more sense.

dump_seek() in particular was too big to be an inline function anyway,
and none of them are in any way performance-critical.  And we really
don't need to mess up our include file headers more than they already
are.

Reported-and-tested-by: Tony Luck <tony.luck@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent ae42d8d
History
File Mode Size
Kconfig -rw-r--r-- 4.1 KB
Makefile -rw-r--r-- 429 bytes
dir.c -rw-r--r-- 30.8 KB
file.c -rw-r--r-- 6.9 KB
getopt.c -rw-r--r-- 1.9 KB
getopt.h -rw-r--r-- 367 bytes
inode.c -rw-r--r-- 26.3 KB
ioctl.c -rw-r--r-- 21.7 KB
mmap.c -rw-r--r-- 2.9 KB
ncplib_kernel.c -rw-r--r-- 32.3 KB
ncplib_kernel.h -rw-r--r-- 7.6 KB
ncpsign_kernel.c -rw-r--r-- 3.6 KB
ncpsign_kernel.h -rw-r--r-- 727 bytes
sock.c -rw-r--r-- 22.8 KB
symlink.c -rw-r--r-- 4.3 KB

back to top