Revision 3aa0ce825ade0cf5506e32ccf51d01fc8d22a9cf authored by Linus Torvalds on 14 October 2010, 21:32:06 UTC, committed by Linus Torvalds on 14 October 2010, 21:32:06 UTC
Tony Luck reports that the addition of the access_ok() check in commit 0eead9ab41da ("Don't dump task struct in a.out core-dumps") broke the ia64 compile due to missing the necessary header file includes. Rather than add yet another include (<asm/unistd.h>) to make everything happy, just uninline the silly core dump helper functions and move the bodies to fs/exec.c where they make a lot more sense. dump_seek() in particular was too big to be an inline function anyway, and none of them are in any way performance-critical. And we really don't need to mess up our include file headers more than they already are. Reported-and-tested-by: Tony Luck <tony.luck@gmail.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent ae42d8d
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 4.0 KB |
Makefile | -rw-r--r-- | 672 bytes |
cache_lib.c | -rw-r--r-- | 3.4 KB |
cache_lib.h | -rw-r--r-- | 790 bytes |
callback.c | -rw-r--r-- | 9.5 KB |
callback.h | -rw-r--r-- | 3.6 KB |
callback_proc.c | -rw-r--r-- | 10.3 KB |
callback_xdr.c | -rw-r--r-- | 19.5 KB |
client.c | -rw-r--r-- | 44.7 KB |
delegation.c | -rw-r--r-- | 14.7 KB |
delegation.h | -rw-r--r-- | 2.5 KB |
dir.c | -rw-r--r-- | 52.9 KB |
direct.c | -rw-r--r-- | 27.2 KB |
dns_resolve.c | -rw-r--r-- | 7.8 KB |
dns_resolve.h | -rw-r--r-- | 527 bytes |
file.c | -rw-r--r-- | 23.1 KB |
fscache-index.c | -rw-r--r-- | 9.3 KB |
fscache.c | -rw-r--r-- | 14.0 KB |
fscache.h | -rw-r--r-- | 6.4 KB |
getroot.c | -rw-r--r-- | 5.9 KB |
idmap.c | -rw-r--r-- | 12.8 KB |
inode.c | -rw-r--r-- | 45.0 KB |
internal.h | -rw-r--r-- | 9.6 KB |
iostat.h | -rw-r--r-- | 1.6 KB |
mount_clnt.c | -rw-r--r-- | 11.9 KB |
namespace.c | -rw-r--r-- | 6.7 KB |
nfs2xdr.c | -rw-r--r-- | 19.3 KB |
nfs3acl.c | -rw-r--r-- | 10.2 KB |
nfs3proc.c | -rw-r--r-- | 21.5 KB |
nfs3xdr.c | -rw-r--r-- | 29.3 KB |
nfs4_fs.h | -rw-r--r-- | 12.1 KB |
nfs4namespace.c | -rw-r--r-- | 6.6 KB |
nfs4proc.c | -rw-r--r-- | 145.2 KB |
nfs4renewd.c | -rw-r--r-- | 4.0 KB |
nfs4state.c | -rw-r--r-- | 40.5 KB |
nfs4xdr.c | -rw-r--r-- | 156.0 KB |
nfsroot.c | -rw-r--r-- | 14.6 KB |
pagelist.c | -rw-r--r-- | 11.2 KB |
proc.c | -rw-r--r-- | 18.4 KB |
read.c | -rw-r--r-- | 16.5 KB |
super.c | -rw-r--r-- | 77.0 KB |
symlink.c | -rw-r--r-- | 1.6 KB |
sysctl.c | -rw-r--r-- | 1.8 KB |
unlink.c | -rw-r--r-- | 7.2 KB |
write.c | -rw-r--r-- | 40.7 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...