Revision 3aa0ce825ade0cf5506e32ccf51d01fc8d22a9cf authored by Linus Torvalds on 14 October 2010, 21:32:06 UTC, committed by Linus Torvalds on 14 October 2010, 21:32:06 UTC
Tony Luck reports that the addition of the access_ok() check in commit
0eead9ab41da ("Don't dump task struct in a.out core-dumps") broke the
ia64 compile due to missing the necessary header file includes.

Rather than add yet another include (<asm/unistd.h>) to make everything
happy, just uninline the silly core dump helper functions and move the
bodies to fs/exec.c where they make a lot more sense.

dump_seek() in particular was too big to be an inline function anyway,
and none of them are in any way performance-critical.  And we really
don't need to mess up our include file headers more than they already
are.

Reported-and-tested-by: Tony Luck <tony.luck@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent ae42d8d
History
File Mode Size
Makefile -rw-r--r-- 150 bytes
heartbeat.c -rw-r--r-- 49.5 KB
heartbeat.h -rw-r--r-- 2.5 KB
masklog.c -rw-r--r-- 4.2 KB
masklog.h -rw-r--r-- 11.0 KB
netdebug.c -rw-r--r-- 10.4 KB
nodemanager.c -rw-r--r-- 24.6 KB
nodemanager.h -rw-r--r-- 2.6 KB
ocfs2_heartbeat.h -rw-r--r-- 1.1 KB
ocfs2_nodemanager.h -rw-r--r-- 1.3 KB
quorum.c -rw-r--r-- 10.1 KB
quorum.h -rw-r--r-- 1.1 KB
sys.c -rw-r--r-- 2.1 KB
sys.h -rw-r--r-- 1011 bytes
tcp.c -rw-r--r-- 56.3 KB
tcp.h -rw-r--r-- 3.9 KB
tcp_internal.h -rw-r--r-- 7.5 KB
ver.c -rw-r--r-- 1.2 KB
ver.h -rw-r--r-- 1008 bytes

back to top