Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision 3aac7ada64d8c26ccc922f1ca966043c0dae88da authored by Liang He on 21 September 2022, 13:32:45 UTC, committed by Jakub Kicinski on 22 September 2022, 14:23:58 UTC 
net: marvell: Fix refcounting bugs in prestera_port_sfp_bind()
 
In prestera_port_sfp_bind(), there are two refcounting bugs:
(1) we should call of_node_get() before of_find_node_by_name() as
it will automaitcally decrease the refcount of 'from' argument;
(2) we should call of_node_put() for the break of the iteration
for_each_child_of_node() as it will automatically increase and
decrease the 'child'.

Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
Signed-off-by: Liang He <windhl@126.com>
Reviewed-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
Link: https://lore.kernel.org/r/20220921133245.4111672-1-windhl@126.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent c2e1cfe
Raw File
Tip revision: 3aac7ada64d8c26ccc922f1ca966043c0dae88da authored by Liang He on 21 September 2022, 13:32:45 UTC
net: marvell: Fix refcounting bugs in prestera_port_sfp_bind()
Tip revision: 3aac7ad
locking-selftest-rlock-hardirq.h 
#include "locking-selftest-rlock.h"
#include "locking-selftest-hardirq.h"
back to top