Revision 3af57f78c38131b7a66e2b01e06fdacae01992a3 authored by Heiko Carstens on 17 January 2014, 08:37:15 UTC, committed by David S. Miller on 18 January 2014, 02:54:49 UTC
The s390 bpf jit compiler emits the signed divide instructions "dr" and "d"
for unsigned divisions.
This can cause problems: the dividend will be zero extended to a 64 bit value
and the divisor is the 32 bit signed value as specified A or X accumulator,
even though A and X are supposed to be treated as unsigned values.

The divide instrunctions will generate an exception if the result cannot be
expressed with a 32 bit signed value.
This is the case if e.g. the dividend is 0xffffffff and the divisor either 1
or also 0xffffffff (signed: -1).

To avoid all these issues simply use unsigned divide instructions.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 75b99db
History
File Mode Size
bnx2-mips-06-6.2.1.fw.ihex -rw-r--r-- 249.6 KB
bnx2-mips-09-6.2.1a.fw.ihex -rw-r--r-- 279.4 KB
bnx2-rv2p-06-6.0.15.fw.ihex -rw-r--r-- 15.6 KB
bnx2-rv2p-09-6.0.17.fw.ihex -rw-r--r-- 16.7 KB
bnx2-rv2p-09ax-6.0.17.fw.ihex -rw-r--r-- 18.1 KB

back to top