Revision 3b2e2904deb314cc77a2192f506f2fd44e3d10d0 authored by Nikolay Aleksandrov on 11 April 2019, 10:56:39 UTC, committed by David S. Miller on 17 April 2019, 03:30:40 UTC
When the commit below was introduced it changed two visible things: - the skb was no longer passed through the protocol handlers with the original device - the skb was passed up the stack with skb->dev = bridge The first change broke af_packet sockets on bridge ports. For example we use them for hostapd which listens for ETH_P_PAE packets on the ports. We discussed two possible fixes: - create a clone and pass it through NF_HOOK(), act on the original skb based on the result - somehow signal to the caller from the okfn() that it was called, meaning the skb is ok to be passed, which this patch is trying to implement via returning 1 from the bridge link-local okfn() Note that we rely on the fact that NF_QUEUE/STOLEN would return 0 and drop/error would return < 0 thus the okfn() is called only when the return was 1, so we signal to the caller that it was called by preserving the return value from nf_hook(). Fixes: 8626c56c8279 ("bridge: fix potential use-after-free when hook returns QUEUE or STOLEN verdict") Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 614c70f
File | Mode | Size |
---|---|---|
ARM-gcc.h | -rw-r--r-- | 4.4 KB |
ChangeLog | -rw-r--r-- | 4.3 KB |
Makefile | -rw-r--r-- | 333 bytes |
double_cpdo.c | -rw-r--r-- | 4.0 KB |
entry.S | -rw-r--r-- | 4.5 KB |
extended_cpdo.c | -rw-r--r-- | 4.0 KB |
fpa11.c | -rw-r--r-- | 3.0 KB |
fpa11.h | -rw-r--r-- | 3.9 KB |
fpa11.inl | -rw-r--r-- | 1.6 KB |
fpa11_cpdo.c | -rw-r--r-- | 3.7 KB |
fpa11_cpdt.c | -rw-r--r-- | 8.9 KB |
fpa11_cprt.c | -rw-r--r-- | 9.0 KB |
fpmodule.c | -rw-r--r-- | 5.2 KB |
fpmodule.h | -rw-r--r-- | 1.3 KB |
fpmodule.inl | -rw-r--r-- | 2.2 KB |
fpopcode.c | -rw-r--r-- | 2.2 KB |
fpopcode.h | -rw-r--r-- | 15.1 KB |
fpsr.h | -rw-r--r-- | 3.8 KB |
milieu.h | -rw-r--r-- | 1.9 KB |
single_cpdo.c | -rw-r--r-- | 3.5 KB |
softfloat-macros | -rw-r--r-- | 23.7 KB |
softfloat-specialize | -rw-r--r-- | 12.0 KB |
softfloat.c | -rw-r--r-- | 116.1 KB |
softfloat.h | -rw-r--r-- | 9.8 KB |
Computing file changes ...