Revision 3b2e2904deb314cc77a2192f506f2fd44e3d10d0 authored by Nikolay Aleksandrov on 11 April 2019, 10:56:39 UTC, committed by David S. Miller on 17 April 2019, 03:30:40 UTC
When the commit below was introduced it changed two visible things: - the skb was no longer passed through the protocol handlers with the original device - the skb was passed up the stack with skb->dev = bridge The first change broke af_packet sockets on bridge ports. For example we use them for hostapd which listens for ETH_P_PAE packets on the ports. We discussed two possible fixes: - create a clone and pass it through NF_HOOK(), act on the original skb based on the result - somehow signal to the caller from the okfn() that it was called, meaning the skb is ok to be passed, which this patch is trying to implement via returning 1 from the bridge link-local okfn() Note that we rely on the fact that NF_QUEUE/STOLEN would return 0 and drop/error would return < 0 thus the okfn() is called only when the return was 1, so we signal to the caller that it was called by preserving the return value from nf_hook(). Fixes: 8626c56c8279 ("bridge: fix potential use-after-free when hook returns QUEUE or STOLEN verdict") Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 614c70f
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 400 bytes |
Makefile | -rw-r--r-- | 296 bytes |
async_memcpy.c | -rw-r--r-- | 3.2 KB |
async_pq.c | -rw-r--r-- | 13.1 KB |
async_raid6_recov.c | -rw-r--r-- | 14.9 KB |
async_tx.c | -rw-r--r-- | 7.7 KB |
async_xor.c | -rw-r--r-- | 9.8 KB |
raid6test.c | -rw-r--r-- | 6.5 KB |
Computing file changes ...