Revision 3b5fa6bd9bc2cdef7535901c73c759fa18092522 authored by Igor Canadi on 02 May 2014, 14:13:51 UTC, committed by Igor Canadi on 02 May 2014, 14:13:51 UTC
Summary:
Our valgrind tests are failing because ttl_test is kind of flakey. This diff should fix valgrind issue and make ttl_test less flakey and much faster.

Instead of relying on Env::Default() for getting current time, I expose `Env*` to all TTL functions that are interested in time. That way, I can insert a custom test Env which is then used to provide exactly the times we need. That way, we don't need to sleep anymore -- we control the time.

Test Plan: ttl_test in normal and valgrind run

Reviewers: dhruba, haobo, sdong, yhchiang

Reviewed By: haobo

CC: leveldb

Differential Revision: https://reviews.facebook.net/D18399
1 parent 82042f4
History
File Mode Size
README -rw-r--r-- 1.1 KB
env_hdfs.h -rw-r--r-- 9.8 KB
hdfs.h -rw-r--r-- 16.2 KB
libhdfs.a -rw-r--r-- 63.7 KB

README

back to top