Revision 3b7995a98ad76da5597b488fa84aa5a56d43b608 authored by Yang Yingliang on 18 December 2019, 08:44:04 UTC, committed by Jens Axboe on 20 December 2019, 18:52:01 UTC
When I doing fuzzy test, get the memleak report:

BUG: memory leak
unreferenced object 0xffff88837af80000 (size 4096):
  comm "memleak", pid 3557, jiffies 4294817681 (age 112.499s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    20 00 00 00 10 01 00 00 00 00 00 00 01 00 00 00   ...............
  backtrace:
    [<000000001c894df8>] bio_alloc_bioset+0x393/0x590
    [<000000008b139a3c>] bio_copy_user_iov+0x300/0xcd0
    [<00000000a998bd8c>] blk_rq_map_user_iov+0x2f1/0x5f0
    [<000000005ceb7f05>] blk_rq_map_user+0xf2/0x160
    [<000000006454da92>] sg_common_write.isra.21+0x1094/0x1870
    [<00000000064bb208>] sg_write.part.25+0x5d9/0x950
    [<000000004fc670f6>] sg_write+0x5f/0x8c
    [<00000000b0d05c7b>] __vfs_write+0x7c/0x100
    [<000000008e177714>] vfs_write+0x1c3/0x500
    [<0000000087d23f34>] ksys_write+0xf9/0x200
    [<000000002c8dbc9d>] do_syscall_64+0x9f/0x4f0
    [<00000000678d8e9a>] entry_SYSCALL_64_after_hwframe+0x49/0xbe

If __blk_rq_map_user_iov() is failed in blk_rq_map_user_iov(),
the bio(s) which is allocated before this failing will leak. The
refcount of the bio(s) is init to 1 and increased to 2 by calling
bio_get(), but __blk_rq_unmap_user() only decrease it to 1, so
the bio cannot be freed. Fix it by calling blk_rq_unmap_user().

Reviewed-by: Bob Liu <bob.liu@oracle.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent daa400f
History
File Mode Size
aoe
drbd
mtip32xx
paride
rsxx
xen-blkback
zram
Kconfig -rw-r--r-- 16.3 KB
Makefile -rw-r--r-- 1.4 KB
amiflop.c -rw-r--r-- 50.0 KB
ataflop.c -rw-r--r-- 54.6 KB
brd.c -rw-r--r-- 12.9 KB
cryptoloop.c -rw-r--r-- 4.3 KB
floppy.c -rw-r--r-- 127.4 KB
loop.c -rw-r--r-- 57.0 KB
loop.h -rw-r--r-- 2.3 KB
nbd.c -rw-r--r-- 60.1 KB
null_blk.h -rw-r--r-- 3.6 KB
null_blk_main.c -rw-r--r-- 45.0 KB
null_blk_zoned.c -rw-r--r-- 5.4 KB
pktcdvd.c -rw-r--r-- 73.0 KB
ps3disk.c -rw-r--r-- 13.5 KB
ps3vram.c -rw-r--r-- 22.1 KB
rbd.c -rw-r--r-- 184.5 KB
rbd_types.h -rw-r--r-- 2.5 KB
skd_main.c -rw-r--r-- 93.1 KB
skd_s1120.h -rw-r--r-- 9.3 KB
sunvdc.c -rw-r--r-- 28.7 KB
swim.c -rw-r--r-- 20.2 KB
swim3.c -rw-r--r-- 31.3 KB
swim_asm.S -rw-r--r-- 4.4 KB
sx8.c -rw-r--r-- 37.2 KB
umem.c -rw-r--r-- 29.8 KB
umem.h -rw-r--r-- 3.6 KB
virtio_blk.c -rw-r--r-- 27.0 KB
xen-blkfront.c -rw-r--r-- 73.6 KB
xsysace.c -rw-r--r-- 33.4 KB
z2ram.c -rw-r--r-- 9.5 KB

back to top