Revision 3b7995a98ad76da5597b488fa84aa5a56d43b608 authored by Yang Yingliang on 18 December 2019, 08:44:04 UTC, committed by Jens Axboe on 20 December 2019, 18:52:01 UTC
When I doing fuzzy test, get the memleak report:
BUG: memory leak
unreferenced object 0xffff88837af80000 (size 4096):
comm "memleak", pid 3557, jiffies 4294817681 (age 112.499s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
20 00 00 00 10 01 00 00 00 00 00 00 01 00 00 00 ...............
backtrace:
[<000000001c894df8>] bio_alloc_bioset+0x393/0x590
[<000000008b139a3c>] bio_copy_user_iov+0x300/0xcd0
[<00000000a998bd8c>] blk_rq_map_user_iov+0x2f1/0x5f0
[<000000005ceb7f05>] blk_rq_map_user+0xf2/0x160
[<000000006454da92>] sg_common_write.isra.21+0x1094/0x1870
[<00000000064bb208>] sg_write.part.25+0x5d9/0x950
[<000000004fc670f6>] sg_write+0x5f/0x8c
[<00000000b0d05c7b>] __vfs_write+0x7c/0x100
[<000000008e177714>] vfs_write+0x1c3/0x500
[<0000000087d23f34>] ksys_write+0xf9/0x200
[<000000002c8dbc9d>] do_syscall_64+0x9f/0x4f0
[<00000000678d8e9a>] entry_SYSCALL_64_after_hwframe+0x49/0xbe
If __blk_rq_map_user_iov() is failed in blk_rq_map_user_iov(),
the bio(s) which is allocated before this failing will leak. The
refcount of the bio(s) is init to 1 and increased to 2 by calling
bio_get(), but __blk_rq_unmap_user() only decrease it to 1, so
the bio cannot be freed. Fix it by calling blk_rq_unmap_user().
Reviewed-by: Bob Liu <bob.liu@oracle.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent daa400f
| File | Mode | Size |
|---|---|---|
| iscsi | ||
| loopback | ||
| sbp | ||
| tcm_fc | ||
| Kconfig | -rw-r--r-- | 1.5 KB |
| Makefile | -rw-r--r-- | 939 bytes |
| target_core_alua.c | -rw-r--r-- | 59.9 KB |
| target_core_alua.h | -rw-r--r-- | 6.0 KB |
| target_core_configfs.c | -rw-r--r-- | 95.1 KB |
| target_core_device.c | -rw-r--r-- | 30.5 KB |
| target_core_fabric_configfs.c | -rw-r--r-- | 27.2 KB |
| target_core_fabric_lib.c | -rw-r--r-- | 11.0 KB |
| target_core_file.c | -rw-r--r-- | 24.3 KB |
| target_core_file.h | -rw-r--r-- | 1.2 KB |
| target_core_hba.c | -rw-r--r-- | 4.0 KB |
| target_core_iblock.c | -rw-r--r-- | 21.4 KB |
| target_core_iblock.h | -rw-r--r-- | 623 bytes |
| target_core_internal.h | -rw-r--r-- | 6.7 KB |
| target_core_pr.c | -rw-r--r-- | 122.2 KB |
| target_core_pr.h | -rw-r--r-- | 2.5 KB |
| target_core_pscsi.c | -rw-r--r-- | 27.5 KB |
| target_core_pscsi.h | -rw-r--r-- | 1.3 KB |
| target_core_rd.c | -rw-r--r-- | 15.7 KB |
| target_core_rd.h | -rw-r--r-- | 1.5 KB |
| target_core_sbc.c | -rw-r--r-- | 37.3 KB |
| target_core_spc.c | -rw-r--r-- | 38.2 KB |
| target_core_stat.c | -rw-r--r-- | 36.4 KB |
| target_core_tmr.c | -rw-r--r-- | 11.3 KB |
| target_core_tpg.c | -rw-r--r-- | 17.1 KB |
| target_core_transport.c | -rw-r--r-- | 92.2 KB |
| target_core_ua.c | -rw-r--r-- | 8.2 KB |
| target_core_ua.h | -rw-r--r-- | 1.7 KB |
| target_core_user.c | -rw-r--r-- | 69.0 KB |
| target_core_xcopy.c | -rw-r--r-- | 28.7 KB |
| target_core_xcopy.h | -rw-r--r-- | 1.9 KB |
Computing file changes ...
