https://github.com/facebookresearch/pythia
Revision 3ba4725e067b439ef7997b9063e3986ea938a3b4 authored by Amanpreet Singh on 19 March 2021, 22:17:27 UTC, committed by Facebook GitHub Bot on 19 March 2021, 22:18:53 UTC
Summary: The calculation of length for multidataloader used get_batch_size to divide total dataset length which is incorrect as get_batch_size is per device rather than global batch size. This PR fixes it and fixes snapshot interval calculation as well. This in turn: - Fixes max_epochs support - ETA - All other things dependent on this Pull Request resolved: https://github.com/facebookresearch/mmf/pull/820 Test Plan: Tested locally with MVLT runs Reviewed By: ytsheng, madian9 Differential Revision: D27184804 Pulled By: apsdehal fbshipit-source-id: d18aeb52b7e280f33c3b9e7509dafa123ed1c629
1 parent 08fb370
Tip revision: 3ba4725e067b439ef7997b9063e3986ea938a3b4 authored by Amanpreet Singh on 19 March 2021, 22:17:27 UTC
[fix] length for multi dataset loader; max_epochs; eta (#820)
[fix] length for multi dataset loader; max_epochs; eta (#820)
Tip revision: 3ba4725
| File | Mode | Size |
|---|---|---|
| .circleci | ||
| .github | ||
| docs | ||
| mmf | ||
| mmf_cli | ||
| projects | ||
| tests | ||
| tools | ||
| website | ||
| .editorconfig | -rw-r--r-- | 191 bytes |
| .flake8 | -rw-r--r-- | 187 bytes |
| .gitignore | -rw-r--r-- | 267 bytes |
| .pre-commit-config.yaml | -rw-r--r-- | 1.1 KB |
| LICENSE | -rw-r--r-- | 1.5 KB |
| MANIFEST.in | -rw-r--r-- | 130 bytes |
| NOTICES | -rw-r--r-- | 2.7 KB |
| README.md | -rw-r--r-- | 2.2 KB |
| pyproject.toml | -rw-r--r-- | 915 bytes |
| requirements.txt | -rw-r--r-- | 351 bytes |
| setup.py | -rw-r--r-- | 5.0 KB |
Computing file changes ...
