https://github.com/torvalds/linux
Revision 3bafeb6247042dcbb72b0141ec7c7107de9f0b99 authored by Linus Torvalds on 05 June 2010, 17:17:36 UTC, committed by Rusty Russell on 05 June 2010, 01:47:37 UTC
I think Rusty may have made the lock a bit _too_ finegrained there, and
didn't add it to some places that needed it. It looks, for example, like
PATCH 1/2 actually drops the lock in places where it's needed
("find_module()" is documented to need it, but now load_module() didn't
hold it at all when it did the find_module()).

Rather than adding a new "module_loading" list, I think we should be able
to just use the existing "modules" list, and just fix up the locking a
bit.

In fact, maybe we could just move the "look up existing module" a bit
later - optimistically assuming that the module doesn't exist, and then
just undoing the work if it turns out that we were wrong, just before
adding ourselves to the list.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1 parent 7567650
History
Tip revision: 3bafeb6247042dcbb72b0141ec7c7107de9f0b99 authored by Linus Torvalds on 05 June 2010, 17:17:36 UTC
module: move find_module check to end
Tip revision: 3bafeb6
File Mode Size
Documentation
arch
block
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.gitignore -rw-r--r-- 936 bytes
.mailmap -rw-r--r-- 3.9 KB
COPYING -rw-r--r-- 18.3 KB
CREDITS -rw-r--r-- 91.8 KB
Kbuild -rw-r--r-- 2.4 KB
MAINTAINERS -rw-r--r-- 170.0 KB
Makefile -rw-r--r-- 52.6 KB
README -rw-r--r-- 17.0 KB
REPORTING-BUGS -rw-r--r-- 3.3 KB

README

back to top