Revision 3cec638b3d793b7cacdec5b8072364b41caeb0e1 authored by Steven Rostedt (VMware) on 10 December 2018, 02:17:30 UTC, committed by Steven Rostedt (VMware) on 11 December 2018, 18:50:19 UTC
When create_event_filter() fails in set_trigger_filter(), the filter may
still be allocated and needs to be freed. The caller expects the
data->filter to be updated with the new filter, even if the new filter
failed (we could add an error message by setting set_str parameter of
create_event_filter(), but that's another update).

But because the error would just exit, filter was left hanging and
nothing could free it.

Found by kmemleak detector.

Cc: stable@vger.kernel.org
Fixes: bac5fb97a173a ("tracing: Add and use generic set_trigger_filter() implementation")
Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
1 parent b61c192
History
File Mode Size
CREDITS -rw-r--r-- 1.9 KB
HiSax.cert -rw-r--r-- 3.9 KB
INTERFACE -rw-r--r-- 27.2 KB
INTERFACE.CAPI -rw-r--r-- 14.1 KB
INTERFACE.fax -rw-r--r-- 4.5 KB
README -rw-r--r-- 28.6 KB
README.FAQ -rw-r--r-- 733 bytes
README.HiSax -rw-r--r-- 23.3 KB
README.audio -rw-r--r-- 5.8 KB
README.avmb1 -rw-r--r-- 5.5 KB
README.concap -rw-r--r-- 10.5 KB
README.diversion -rw-r--r-- 6.1 KB
README.fax -rw-r--r-- 1.1 KB
README.gigaset -rw-r--r-- 17.8 KB
README.hfc-pci -rw-r--r-- 1.8 KB
README.hysdn -rw-r--r-- 7.8 KB
README.mISDN -rw-r--r-- 328 bytes
README.syncppp -rw-r--r-- 2.1 KB
README.x25 -rw-r--r-- 7.1 KB
syncPPP.FAQ -rw-r--r-- 7.9 KB

README

back to top