Revision 3cec638b3d793b7cacdec5b8072364b41caeb0e1 authored by Steven Rostedt (VMware) on 10 December 2018, 02:17:30 UTC, committed by Steven Rostedt (VMware) on 11 December 2018, 18:50:19 UTC
When create_event_filter() fails in set_trigger_filter(), the filter may
still be allocated and needs to be freed. The caller expects the
data->filter to be updated with the new filter, even if the new filter
failed (we could add an error message by setting set_str parameter of
create_event_filter(), but that's another update).

But because the error would just exit, filter was left hanging and
nothing could free it.

Found by kmemleak detector.

Cc: stable@vger.kernel.org
Fixes: bac5fb97a173a ("tracing: Add and use generic set_trigger_filter() implementation")
Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
1 parent b61c192
History
File Mode Size
Kconfig -rw-r--r-- 1.2 KB
Makefile -rw-r--r-- 287 bytes
acl.c -rw-r--r-- 8.0 KB
acl.h -rw-r--r-- 1.7 KB
cache.c -rw-r--r-- 8.6 KB
cache.h -rw-r--r-- 4.4 KB
fid.c -rw-r--r-- 6.8 KB
fid.h -rw-r--r-- 1.3 KB
v9fs.c -rw-r--r-- 16.8 KB
v9fs.h -rw-r--r-- 7.4 KB
v9fs_vfs.h -rw-r--r-- 3.6 KB
vfs_addr.c -rw-r--r-- 8.2 KB
vfs_dentry.c -rw-r--r-- 3.1 KB
vfs_dir.c -rw-r--r-- 5.4 KB
vfs_file.c -rw-r--r-- 17.1 KB
vfs_inode.c -rw-r--r-- 34.0 KB
vfs_inode_dotl.c -rw-r--r-- 24.4 KB
vfs_super.c -rw-r--r-- 8.6 KB
xattr.c -rw-r--r-- 5.1 KB
xattr.h -rw-r--r-- 1.2 KB

back to top