Revision 3cec638b3d793b7cacdec5b8072364b41caeb0e1 authored by Steven Rostedt (VMware) on 10 December 2018, 02:17:30 UTC, committed by Steven Rostedt (VMware) on 11 December 2018, 18:50:19 UTC
When create_event_filter() fails in set_trigger_filter(), the filter may
still be allocated and needs to be freed. The caller expects the
data->filter to be updated with the new filter, even if the new filter
failed (we could add an error message by setting set_str parameter of
create_event_filter(), but that's another update).

But because the error would just exit, filter was left hanging and
nothing could free it.

Found by kmemleak detector.

Cc: stable@vger.kernel.org
Fixes: bac5fb97a173a ("tracing: Add and use generic set_trigger_filter() implementation")
Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
1 parent b61c192
History
File Mode Size
Kconfig -rw-r--r-- 4.6 KB
Makefile -rw-r--r-- 294 bytes
cache.c -rw-r--r-- 9.4 KB
dir.c -rw-r--r-- 34.9 KB
fat.h -rw-r--r-- 14.5 KB
fatent.c -rw-r--r-- 19.0 KB
file.c -rw-r--r-- 14.2 KB
inode.c -rw-r--r-- 50.7 KB
misc.c -rw-r--r-- 9.3 KB
namei_msdos.c -rw-r--r-- 16.7 KB
namei_vfat.c -rw-r--r-- 25.4 KB
nfs.c -rw-r--r-- 7.8 KB

back to top