Revision 3cec638b3d793b7cacdec5b8072364b41caeb0e1 authored by Steven Rostedt (VMware) on 10 December 2018, 02:17:30 UTC, committed by Steven Rostedt (VMware) on 11 December 2018, 18:50:19 UTC
When create_event_filter() fails in set_trigger_filter(), the filter may
still be allocated and needs to be freed. The caller expects the
data->filter to be updated with the new filter, even if the new filter
failed (we could add an error message by setting set_str parameter of
create_event_filter(), but that's another update).
But because the error would just exit, filter was left hanging and
nothing could free it.
Found by kmemleak detector.
Cc: stable@vger.kernel.org
Fixes: bac5fb97a173a ("tracing: Add and use generic set_trigger_filter() implementation")
Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
1 parent b61c192
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 5.5 KB |
| LICENCE | -rw-r--r-- | 1.4 KB |
| Makefile | -rw-r--r-- | 786 bytes |
| README.Locking | -rw-r--r-- | 6.9 KB |
| TODO | -rw-r--r-- | 1.9 KB |
| acl.c | -rw-r--r-- | 6.7 KB |
| acl.h | -rw-r--r-- | 966 bytes |
| background.c | -rw-r--r-- | 4.2 KB |
| build.c | -rw-r--r-- | 12.6 KB |
| compr.c | -rw-r--r-- | 11.6 KB |
| compr.h | -rw-r--r-- | 3.1 KB |
| compr_lzo.c | -rw-r--r-- | 2.2 KB |
| compr_rtime.c | -rw-r--r-- | 2.8 KB |
| compr_rubin.c | -rw-r--r-- | 8.7 KB |
| compr_zlib.c | -rw-r--r-- | 5.5 KB |
| debug.c | -rw-r--r-- | 25.6 KB |
| debug.h | -rw-r--r-- | 7.9 KB |
| dir.c | -rw-r--r-- | 22.6 KB |
| erase.c | -rw-r--r-- | 13.4 KB |
| file.c | -rw-r--r-- | 9.1 KB |
| fs.c | -rw-r--r-- | 19.8 KB |
| gc.c | -rw-r--r-- | 43.9 KB |
| ioctl.c | -rw-r--r-- | 557 bytes |
| jffs2_fs_i.h | -rw-r--r-- | 1.6 KB |
| jffs2_fs_sb.h | -rw-r--r-- | 5.7 KB |
| malloc.c | -rw-r--r-- | 7.3 KB |
| nodelist.c | -rw-r--r-- | 21.3 KB |
| nodelist.h | -rw-r--r-- | 17.9 KB |
| nodemgmt.c | -rw-r--r-- | 28.4 KB |
| os-linux.h | -rw-r--r-- | 7.5 KB |
| read.c | -rw-r--r-- | 6.7 KB |
| readinode.c | -rw-r--r-- | 42.9 KB |
| scan.c | -rw-r--r-- | 35.2 KB |
| security.c | -rw-r--r-- | 1.9 KB |
| summary.c | -rw-r--r-- | 23.6 KB |
| summary.h | -rw-r--r-- | 6.3 KB |
| super.c | -rw-r--r-- | 10.2 KB |
| symlink.c | -rw-r--r-- | 417 bytes |
| wbuf.c | -rw-r--r-- | 36.9 KB |
| write.c | -rw-r--r-- | 21.0 KB |
| writev.c | -rw-r--r-- | 1.1 KB |
| xattr.c | -rw-r--r-- | 38.3 KB |
| xattr.h | -rw-r--r-- | 4.1 KB |
| xattr_trusted.c | -rw-r--r-- | 1.2 KB |
| xattr_user.c | -rw-r--r-- | 1.1 KB |
Computing file changes ...
