Revision 3cec638b3d793b7cacdec5b8072364b41caeb0e1 authored by Steven Rostedt (VMware) on 10 December 2018, 02:17:30 UTC, committed by Steven Rostedt (VMware) on 11 December 2018, 18:50:19 UTC
When create_event_filter() fails in set_trigger_filter(), the filter may
still be allocated and needs to be freed. The caller expects the
data->filter to be updated with the new filter, even if the new filter
failed (we could add an error message by setting set_str parameter of
create_event_filter(), but that's another update).
But because the error would just exit, filter was left hanging and
nothing could free it.
Found by kmemleak detector.
Cc: stable@vger.kernel.org
Fixes: bac5fb97a173a ("tracing: Add and use generic set_trigger_filter() implementation")
Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
1 parent b61c192
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 1.4 KB |
| Makefile | -rw-r--r-- | 486 bytes |
| acl.c | -rw-r--r-- | 3.8 KB |
| file.c | -rw-r--r-- | 4.3 KB |
| inode.c | -rw-r--r-- | 10.1 KB |
| ioctl.c | -rw-r--r-- | 3.9 KB |
| jfs_acl.h | -rw-r--r-- | 1.2 KB |
| jfs_btree.h | -rw-r--r-- | 4.0 KB |
| jfs_debug.c | -rw-r--r-- | 2.5 KB |
| jfs_debug.h | -rw-r--r-- | 3.3 KB |
| jfs_dinode.h | -rw-r--r-- | 5.8 KB |
| jfs_discard.c | -rw-r--r-- | 3.1 KB |
| jfs_discard.h | -rw-r--r-- | 1.0 KB |
| jfs_dmap.c | -rw-r--r-- | 111.6 KB |
| jfs_dmap.h | -rw-r--r-- | 11.2 KB |
| jfs_dtree.c | -rw-r--r-- | 100.5 KB |
| jfs_dtree.h | -rw-r--r-- | 6.6 KB |
| jfs_extent.c | -rw-r--r-- | 17.3 KB |
| jfs_extent.h | -rw-r--r-- | 1.3 KB |
| jfs_filsys.h | -rw-r--r-- | 8.9 KB |
| jfs_imap.c | -rw-r--r-- | 83.8 KB |
| jfs_imap.h | -rw-r--r-- | 6.4 KB |
| jfs_incore.h | -rw-r--r-- | 7.5 KB |
| jfs_inode.c | -rw-r--r-- | 3.5 KB |
| jfs_inode.h | -rw-r--r-- | 2.5 KB |
| jfs_lock.h | -rw-r--r-- | 1.5 KB |
| jfs_logmgr.c | -rw-r--r-- | 58.9 KB |
| jfs_logmgr.h | -rw-r--r-- | 14.7 KB |
| jfs_metapage.c | -rw-r--r-- | 19.2 KB |
| jfs_metapage.h | -rw-r--r-- | 4.2 KB |
| jfs_mount.c | -rw-r--r-- | 12.7 KB |
| jfs_superblock.h | -rw-r--r-- | 4.1 KB |
| jfs_txnmgr.c | -rw-r--r-- | 74.6 KB |
| jfs_txnmgr.h | -rw-r--r-- | 8.2 KB |
| jfs_types.h | -rw-r--r-- | 4.3 KB |
| jfs_umount.c | -rw-r--r-- | 4.0 KB |
| jfs_unicode.c | -rw-r--r-- | 3.3 KB |
| jfs_unicode.h | -rw-r--r-- | 3.7 KB |
| jfs_uniupr.c | -rw-r--r-- | 7.5 KB |
| jfs_xattr.h | -rw-r--r-- | 2.5 KB |
| jfs_xtree.c | -rw-r--r-- | 91.8 KB |
| jfs_xtree.h | -rw-r--r-- | 3.8 KB |
| namei.c | -rw-r--r-- | 37.1 KB |
| resize.c | -rw-r--r-- | 14.8 KB |
| super.c | -rw-r--r-- | 24.7 KB |
| symlink.c | -rw-r--r-- | 1.2 KB |
| xattr.c | -rw-r--r-- | 25.8 KB |
Computing file changes ...
