Revision 3cec638b3d793b7cacdec5b8072364b41caeb0e1 authored by Steven Rostedt (VMware) on 10 December 2018, 02:17:30 UTC, committed by Steven Rostedt (VMware) on 11 December 2018, 18:50:19 UTC
When create_event_filter() fails in set_trigger_filter(), the filter may
still be allocated and needs to be freed. The caller expects the
data->filter to be updated with the new filter, even if the new filter
failed (we could add an error message by setting set_str parameter of
create_event_filter(), but that's another update).

But because the error would just exit, filter was left hanging and
nothing could free it.

Found by kmemleak detector.

Cc: stable@vger.kernel.org
Fixes: bac5fb97a173a ("tracing: Add and use generic set_trigger_filter() implementation")
Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
1 parent b61c192
History
File Mode Size
Kconfig -rw-r--r-- 1.1 KB
Makefile -rw-r--r-- 283 bytes
alloc.c -rw-r--r-- 24.3 KB
alloc.h -rw-r--r-- 3.2 KB
bmap.c -rw-r--r-- 14.4 KB
bmap.h -rw-r--r-- 7.8 KB
btnode.c -rw-r--r-- 6.6 KB
btnode.h -rw-r--r-- 1.4 KB
btree.c -rw-r--r-- 62.4 KB
btree.h -rw-r--r-- 2.0 KB
cpfile.c -rw-r--r-- 25.4 KB
cpfile.h -rw-r--r-- 1.1 KB
dat.c -rw-r--r-- 12.7 KB
dat.h -rw-r--r-- 1.7 KB
dir.c -rw-r--r-- 16.6 KB
direct.c -rw-r--r-- 8.7 KB
direct.h -rw-r--r-- 645 bytes
export.h -rw-r--r-- 505 bytes
file.c -rw-r--r-- 3.6 KB
gcinode.c -rw-r--r-- 5.1 KB
ifile.c -rw-r--r-- 5.2 KB
ifile.h -rw-r--r-- 1.1 KB
inode.c -rw-r--r-- 28.8 KB
ioctl.c -rw-r--r-- 35.8 KB
mdt.c -rw-r--r-- 15.5 KB
mdt.h -rw-r--r-- 3.7 KB
namei.c -rw-r--r-- 12.4 KB
nilfs.h -rw-r--r-- 12.1 KB
page.c -rw-r--r-- 13.6 KB
page.h -rw-r--r-- 1.9 KB
recovery.c -rw-r--r-- 23.6 KB
segbuf.c -rw-r--r-- 13.0 KB
segbuf.h -rw-r--r-- 5.5 KB
segment.c -rw-r--r-- 74.1 KB
segment.h -rw-r--r-- 7.8 KB
sufile.c -rw-r--r-- 31.6 KB
sufile.h -rw-r--r-- 4.2 KB
super.c -rw-r--r-- 35.3 KB
sysfs.c -rw-r--r-- 31.3 KB
sysfs.h -rw-r--r-- 5.2 KB
the_nilfs.c -rw-r--r-- 20.6 KB
the_nilfs.h -rw-r--r-- 11.3 KB

back to top