Revision 3cec638b3d793b7cacdec5b8072364b41caeb0e1 authored by Steven Rostedt (VMware) on 10 December 2018, 02:17:30 UTC, committed by Steven Rostedt (VMware) on 11 December 2018, 18:50:19 UTC
When create_event_filter() fails in set_trigger_filter(), the filter may
still be allocated and needs to be freed. The caller expects the
data->filter to be updated with the new filter, even if the new filter
failed (we could add an error message by setting set_str parameter of
create_event_filter(), but that's another update).
But because the error would just exit, filter was left hanging and
nothing could free it.
Found by kmemleak detector.
Cc: stable@vger.kernel.org
Fixes: bac5fb97a173a ("tracing: Add and use generic set_trigger_filter() implementation")
Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
1 parent b61c192
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 3.2 KB |
| Makefile | -rw-r--r-- | 701 bytes |
| README | -rw-r--r-- | 7.9 KB |
| acl.h | -rw-r--r-- | 1.8 KB |
| bitmap.c | -rw-r--r-- | 39.6 KB |
| dir.c | -rw-r--r-- | 9.0 KB |
| do_balan.c | -rw-r--r-- | 54.3 KB |
| file.c | -rw-r--r-- | 7.5 KB |
| fix_node.c | -rw-r--r-- | 77.4 KB |
| hashes.c | -rw-r--r-- | 3.5 KB |
| ibalance.c | -rw-r--r-- | 34.3 KB |
| inode.c | -rw-r--r-- | 92.3 KB |
| ioctl.c | -rw-r--r-- | 5.3 KB |
| item_ops.c | -rw-r--r-- | 18.1 KB |
| journal.c | -rw-r--r-- | 120.5 KB |
| lbalance.c | -rw-r--r-- | 41.3 KB |
| lock.c | -rw-r--r-- | 2.6 KB |
| namei.c | -rw-r--r-- | 43.8 KB |
| objectid.c | -rw-r--r-- | 6.8 KB |
| prints.c | -rw-r--r-- | 21.4 KB |
| procfs.c | -rw-r--r-- | 13.2 KB |
| reiserfs.h | -rw-r--r-- | 116.6 KB |
| resize.c | -rw-r--r-- | 6.3 KB |
| stree.c | -rw-r--r-- | 64.0 KB |
| super.c | -rw-r--r-- | 70.0 KB |
| tail_conversion.c | -rw-r--r-- | 9.2 KB |
| xattr.c | -rw-r--r-- | 24.3 KB |
| xattr.h | -rw-r--r-- | 3.7 KB |
| xattr_acl.c | -rw-r--r-- | 9.6 KB |
| xattr_security.c | -rw-r--r-- | 2.7 KB |
| xattr_trusted.c | -rw-r--r-- | 1.2 KB |
| xattr_user.c | -rw-r--r-- | 1.1 KB |
Computing file changes ...
