Skip to main content

Browse the archive

https://github.com/torvalds/linux
08 September 2024, 02:26:05 UTC
Revision 3ceccb14f5576e02b81cc8b105ab81f224bd87f6 authored by Ilya Dryomov on 23 July 2024, 16:08:08 UTC, committed by Ilya Dryomov on 25 July 2024, 10:18:29 UTC 
rbd: don't assume rbd_is_lock_owner() for exclusive mappings
 
Expanding on the previous commit, assuming that rbd_is_lock_owner()
always returns true (i.e. that we are either in RBD_LOCK_STATE_LOCKED
or RBD_LOCK_STATE_QUIESCING) if the mapping is exclusive is wrong too.
In case ceph_cls_set_cookie() fails, the lock would be temporarily
released even if the mapping is exclusive, meaning that we can end up
even in RBD_LOCK_STATE_UNLOCKED.

IOW, exclusive mappings are really "just" about disabling automatic
lock transitions (as documented in the man page), not about grabbing
the lock and holding on to it whatever it takes.

Cc: stable@vger.kernel.org
Fixes: 637cd060537d ("rbd: new exclusive lock wait/wake code")
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
1 parent 2237ceb
History
Tip revision: 3ceccb14f5576e02b81cc8b105ab81f224bd87f6 authored by Ilya Dryomov on 23 July 2024, 16:08:08 UTC
rbd: don't assume rbd_is_lock_owner() for exclusive mappings
Tip revision: 3ceccb1
File Mode Size
.gitignore -rw-r--r-- 58 bytes
Kconfig -rw-r--r-- 63.1 KB
Makefile -rw-r--r-- 1.8 KB
build-version -rwxr-xr-x 177 bytes
calibrate.c -rw-r--r-- 8.6 KB
do_mounts.c -rw-r--r-- 11.0 KB
do_mounts.h -rw-r--r-- 1.2 KB
do_mounts_initrd.c -rw-r--r-- 3.8 KB
do_mounts_rd.c -rw-r--r-- 7.7 KB
init_task.c -rw-r--r-- 6.2 KB
initramfs.c -rw-r--r-- 17.4 KB
main.c -rw-r--r-- 38.5 KB
noinitramfs.c -rw-r--r-- 862 bytes
version-timestamp.c -rw-r--r-- 762 bytes
version.c -rw-r--r-- 1.3 KB
back to top