https://github.com/torvalds/linux
Revision 3ceccb14f5576e02b81cc8b105ab81f224bd87f6 authored by Ilya Dryomov on 23 July 2024, 16:08:08 UTC, committed by Ilya Dryomov on 25 July 2024, 10:18:29 UTC
Expanding on the previous commit, assuming that rbd_is_lock_owner() always returns true (i.e. that we are either in RBD_LOCK_STATE_LOCKED or RBD_LOCK_STATE_QUIESCING) if the mapping is exclusive is wrong too. In case ceph_cls_set_cookie() fails, the lock would be temporarily released even if the mapping is exclusive, meaning that we can end up even in RBD_LOCK_STATE_UNLOCKED. IOW, exclusive mappings are really "just" about disabling automatic lock transitions (as documented in the man page), not about grabbing the lock and holding on to it whatever it takes. Cc: stable@vger.kernel.org Fixes: 637cd060537d ("rbd: new exclusive lock wait/wake code") Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Reviewed-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
1 parent 2237ceb
Tip revision: 3ceccb14f5576e02b81cc8b105ab81f224bd87f6 authored by Ilya Dryomov on 23 July 2024, 16:08:08 UTC
rbd: don't assume rbd_is_lock_owner() for exclusive mappings
rbd: don't assume rbd_is_lock_owner() for exclusive mappings
Tip revision: 3ceccb1
File | Mode | Size |
---|---|---|
damon | ||
kasan | ||
kfence | ||
kmsan | ||
Kconfig | -rw-r--r-- | 38.8 KB |
Kconfig.debug | -rw-r--r-- | 9.9 KB |
Makefile | -rw-r--r-- | 5.0 KB |
backing-dev.c | -rw-r--r-- | 29.5 KB |
balloon_compaction.c | -rw-r--r-- | 8.2 KB |
bootmem_info.c | -rw-r--r-- | 3.4 KB |
cma.c | -rw-r--r-- | 15.5 KB |
cma.h | -rw-r--r-- | 1.6 KB |
cma_debug.c | -rw-r--r-- | 4.5 KB |
cma_sysfs.c | -rw-r--r-- | 2.9 KB |
compaction.c | -rw-r--r-- | 93.0 KB |
debug.c | -rw-r--r-- | 7.1 KB |
debug_page_alloc.c | -rw-r--r-- | 1.4 KB |
debug_page_ref.c | -rw-r--r-- | 1.4 KB |
debug_vm_pgtable.c | -rw-r--r-- | 39.5 KB |
dmapool.c | -rw-r--r-- | 13.1 KB |
dmapool_test.c | -rw-r--r-- | 2.9 KB |
early_ioremap.c | -rw-r--r-- | 6.7 KB |
execmem.c | -rw-r--r-- | 3.5 KB |
fadvise.c | -rw-r--r-- | 5.5 KB |
fail_page_alloc.c | -rw-r--r-- | 1.6 KB |
failslab.c | -rw-r--r-- | 1.6 KB |
filemap.c | -rw-r--r-- | 124.5 KB |
folio-compat.c | -rw-r--r-- | 2.6 KB |
gup.c | -rw-r--r-- | 104.2 KB |
gup_test.c | -rw-r--r-- | 9.0 KB |
gup_test.h | -rw-r--r-- | 1.2 KB |
highmem.c | -rw-r--r-- | 20.2 KB |
hmm.c | -rw-r--r-- | 17.0 KB |
huge_memory.c | -rw-r--r-- | 100.5 KB |
hugetlb.c | -rw-r--r-- | 217.1 KB |
hugetlb_cgroup.c | -rw-r--r-- | 24.2 KB |
hugetlb_vmemmap.c | -rw-r--r-- | 21.2 KB |
hugetlb_vmemmap.h | -rw-r--r-- | 2.3 KB |
hwpoison-inject.c | -rw-r--r-- | 2.8 KB |
init-mm.c | -rw-r--r-- | 1.7 KB |
internal.h | -rw-r--r-- | 45.7 KB |
interval_tree.c | -rw-r--r-- | 3.1 KB |
io-mapping.c | -rw-r--r-- | 993 bytes |
ioremap.c | -rw-r--r-- | 1.7 KB |
khugepaged.c | -rw-r--r-- | 71.7 KB |
kmemleak.c | -rw-r--r-- | 62.6 KB |
ksm.c | -rw-r--r-- | 108.3 KB |
list_lru.c | -rw-r--r-- | 13.8 KB |
maccess.c | -rw-r--r-- | 5.9 KB |
madvise.c | -rw-r--r-- | 39.9 KB |
mapping_dirty_helpers.c | -rw-r--r-- | 10.4 KB |
memblock.c | -rw-r--r-- | 64.5 KB |
memcontrol.c | -rw-r--r-- | 220.0 KB |
memfd.c | -rw-r--r-- | 9.3 KB |
memory-failure.c | -rw-r--r-- | 74.3 KB |
memory-tiers.c | -rw-r--r-- | 26.2 KB |
memory.c | -rw-r--r-- | 177.1 KB |
memory_hotplug.c | -rw-r--r-- | 68.2 KB |
mempolicy.c | -rw-r--r-- | 89.9 KB |
mempool.c | -rw-r--r-- | 17.5 KB |
memremap.c | -rw-r--r-- | 14.5 KB |
memtest.c | -rw-r--r-- | 3.5 KB |
migrate.c | -rw-r--r-- | 71.2 KB |
migrate_device.c | -rw-r--r-- | 26.8 KB |
mincore.c | -rw-r--r-- | 7.1 KB |
mlock.c | -rw-r--r-- | 20.7 KB |
mm_init.c | -rw-r--r-- | 76.0 KB |
mm_slot.h | -rw-r--r-- | 1.4 KB |
mmap.c | -rw-r--r-- | 107.7 KB |
mmap_lock.c | -rw-r--r-- | 6.2 KB |
mmu_gather.c | -rw-r--r-- | 12.3 KB |
mmu_notifier.c | -rw-r--r-- | 34.1 KB |
mmzone.c | -rw-r--r-- | 2.6 KB |
mprotect.c | -rw-r--r-- | 22.7 KB |
mremap.c | -rw-r--r-- | 31.9 KB |
mseal.c | -rw-r--r-- | 7.1 KB |
msync.c | -rw-r--r-- | 2.9 KB |
nommu.c | -rw-r--r-- | 44.2 KB |
oom_kill.c | -rw-r--r-- | 33.4 KB |
page-writeback.c | -rw-r--r-- | 96.2 KB |
page_alloc.c | -rw-r--r-- | 194.4 KB |
page_counter.c | -rw-r--r-- | 6.8 KB |
page_ext.c | -rw-r--r-- | 14.1 KB |
page_idle.c | -rw-r--r-- | 5.3 KB |
page_io.c | -rw-r--r-- | 13.7 KB |
page_isolation.c | -rw-r--r-- | 20.3 KB |
page_owner.c | -rw-r--r-- | 24.4 KB |
page_poison.c | -rw-r--r-- | 2.5 KB |
page_reporting.c | -rw-r--r-- | 11.7 KB |
page_reporting.h | -rw-r--r-- | 1.6 KB |
page_table_check.c | -rw-r--r-- | 6.7 KB |
page_vma_mapped.c | -rw-r--r-- | 9.5 KB |
pagewalk.c | -rw-r--r-- | 18.7 KB |
percpu-internal.h | -rw-r--r-- | 7.7 KB |
percpu-km.c | -rw-r--r-- | 3.2 KB |
percpu-stats.c | -rw-r--r-- | 5.8 KB |
percpu-vm.c | -rw-r--r-- | 11.7 KB |
percpu.c | -rw-r--r-- | 101.7 KB |
pgalloc-track.h | -rw-r--r-- | 1.3 KB |
pgtable-generic.c | -rw-r--r-- | 11.2 KB |
process_vm_access.c | -rw-r--r-- | 8.3 KB |
ptdump.c | -rw-r--r-- | 4.6 KB |
readahead.c | -rw-r--r-- | 25.6 KB |
rmap.c | -rw-r--r-- | 78.9 KB |
rodata_test.c | -rw-r--r-- | 1.2 KB |
secretmem.c | -rw-r--r-- | 6.4 KB |
shmem.c | -rw-r--r-- | 130.7 KB |
shmem_quota.c | -rw-r--r-- | 9.5 KB |
show_mem.c | -rw-r--r-- | 12.6 KB |
shrinker.c | -rw-r--r-- | 21.3 KB |
shrinker_debug.c | -rw-r--r-- | 6.1 KB |
shuffle.c | -rw-r--r-- | 4.6 KB |
shuffle.h | -rw-r--r-- | 1.2 KB |
slab.h | -rw-r--r-- | 18.4 KB |
slab_common.c | -rw-r--r-- | 33.6 KB |
slub.c | -rw-r--r-- | 181.9 KB |
sparse-vmemmap.c | -rw-r--r-- | 11.9 KB |
sparse.c | -rw-r--r-- | 25.7 KB |
swap.c | -rw-r--r-- | 31.5 KB |
swap.h | -rw-r--r-- | 4.1 KB |
swap_cgroup.c | -rw-r--r-- | 5.2 KB |
swap_slots.c | -rw-r--r-- | 9.3 KB |
swap_state.c | -rw-r--r-- | 25.7 KB |
swapfile.c | -rw-r--r-- | 94.3 KB |
truncate.c | -rw-r--r-- | 25.5 KB |
usercopy.c | -rw-r--r-- | 8.1 KB |
userfaultfd.c | -rw-r--r-- | 45.7 KB |
util.c | -rw-r--r-- | 29.8 KB |
vmalloc.c | -rw-r--r-- | 131.9 KB |
vmpressure.c | -rw-r--r-- | 14.1 KB |
vmscan.c | -rw-r--r-- | 208.0 KB |
vmstat.c | -rw-r--r-- | 55.7 KB |
workingset.c | -rw-r--r-- | 27.4 KB |
z3fold.c | -rw-r--r-- | 36.8 KB |
zbud.c | -rw-r--r-- | 12.8 KB |
zpool.c | -rw-r--r-- | 10.0 KB |
zsmalloc.c | -rw-r--r-- | 54.1 KB |
zswap.c | -rw-r--r-- | 48.5 KB |
Computing file changes ...