https://github.com/torvalds/linux
Revision 3ceccb14f5576e02b81cc8b105ab81f224bd87f6 authored by Ilya Dryomov on 23 July 2024, 16:08:08 UTC, committed by Ilya Dryomov on 25 July 2024, 10:18:29 UTC
Expanding on the previous commit, assuming that rbd_is_lock_owner()
always returns true (i.e. that we are either in RBD_LOCK_STATE_LOCKED
or RBD_LOCK_STATE_QUIESCING) if the mapping is exclusive is wrong too.
In case ceph_cls_set_cookie() fails, the lock would be temporarily
released even if the mapping is exclusive, meaning that we can end up
even in RBD_LOCK_STATE_UNLOCKED.

IOW, exclusive mappings are really "just" about disabling automatic
lock transitions (as documented in the man page), not about grabbing
the lock and holding on to it whatever it takes.

Cc: stable@vger.kernel.org
Fixes: 637cd060537d ("rbd: new exclusive lock wait/wake code")
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
1 parent 2237ceb
History
Tip revision: 3ceccb14f5576e02b81cc8b105ab81f224bd87f6 authored by Ilya Dryomov on 23 July 2024, 16:08:08 UTC
rbd: don't assume rbd_is_lock_owner() for exclusive mappings
Tip revision: 3ceccb1

back to top