https://github.com/torvalds/linux
Revision 3cf6a32f3f2a45944dd5be5c6ac4deb46bcd3bee authored by Michael Petlan on 17 March 2022, 13:55:36 UTC, committed by Arnaldo Carvalho de Melo on 18 March 2022, 21:39:09 UTC
Before this patch, the symbol end address fixup to be called, needed two
conditions being met:

  if (prev->end == prev->start && prev->end != curr->start)

Where
  "prev->end == prev->start" means that prev is zero-long
                             (and thus needs a fixup)
and
  "prev->end != curr->start" means that fixup hasn't been applied yet

However, this logic is incorrect in the following situation:

*curr  = {rb_node = {__rb_parent_color = 278218928,
  rb_right = 0x0, rb_left = 0x0},
  start = 0xc000000000062354,
  end = 0xc000000000062354, namelen = 40, type = 2 '\002',
  binding = 0 '\000', idle = 0 '\000', ignore = 0 '\000',
  inlined = 0 '\000', arch_sym = 0 '\000', annotate2 = false,
  name = 0x1159739e "kprobe_optinsn_page\t[__builtin__kprobes]"}

*prev = {rb_node = {__rb_parent_color = 278219041,
  rb_right = 0x109548b0, rb_left = 0x109547c0},
  start = 0xc000000000062354,
  end = 0xc000000000062354, namelen = 12, type = 2 '\002',
  binding = 1 '\001', idle = 0 '\000', ignore = 0 '\000',
  inlined = 0 '\000', arch_sym = 0 '\000', annotate2 = false,
  name = 0x1095486e "optinsn_slot"}

In this case, prev->start == prev->end == curr->start == curr->end,
thus the condition above thinks that "we need a fixup due to zero
length of prev symbol, but it has been probably done, since the
prev->end == curr->start", which is wrong.

After the patch, the execution path proceeds to arch__symbols__fixup_end
function which fixes up the size of prev symbol by adding page_size to
its end offset.

Fixes: 3b01a413c196c910 ("perf symbols: Improve kallsyms symbol end addr calculation")
Signed-off-by: Michael Petlan <mpetlan@redhat.com>
Cc: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: http://lore.kernel.org/lkml/20220317135536.805-1-mpetlan@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 34e047a
History
Tip revision: 3cf6a32f3f2a45944dd5be5c6ac4deb46bcd3bee authored by Michael Petlan on 17 March 2022, 13:55:36 UTC
perf symbols: Fix symbol size calculation condition
Tip revision: 3cf6a32
File Mode Size
damon
kasan
kfence
Kconfig -rw-r--r-- 27.4 KB
Kconfig.debug -rw-r--r-- 6.4 KB
Makefile -rw-r--r-- 4.8 KB
backing-dev.c -rw-r--r-- 26.4 KB
balloon_compaction.c -rw-r--r-- 8.2 KB
bootmem_info.c -rw-r--r-- 3.3 KB
cma.c -rw-r--r-- 15.7 KB
cma.h -rw-r--r-- 1.4 KB
cma_debug.c -rw-r--r-- 4.5 KB
cma_sysfs.c -rw-r--r-- 2.4 KB
compaction.c -rw-r--r-- 83.6 KB
debug.c -rw-r--r-- 6.9 KB
debug_page_ref.c -rw-r--r-- 1.4 KB
debug_vm_pgtable.c -rw-r--r-- 38.1 KB
dmapool.c -rw-r--r-- 13.6 KB
early_ioremap.c -rw-r--r-- 6.7 KB
fadvise.c -rw-r--r-- 5.3 KB
failslab.c -rw-r--r-- 1.4 KB
filemap.c -rw-r--r-- 111.0 KB
folio-compat.c -rw-r--r-- 3.7 KB
frontswap.c -rw-r--r-- 7.9 KB
gup.c -rw-r--r-- 89.7 KB
gup_test.c -rw-r--r-- 5.6 KB
gup_test.h -rw-r--r-- 938 bytes
highmem.c -rw-r--r-- 19.6 KB
hmm.c -rw-r--r-- 16.8 KB
huge_memory.c -rw-r--r-- 85.6 KB
hugetlb.c -rw-r--r-- 192.5 KB
hugetlb_cgroup.c -rw-r--r-- 24.6 KB
hugetlb_vmemmap.c -rw-r--r-- 13.0 KB
hugetlb_vmemmap.h -rw-r--r-- 1.1 KB
hwpoison-inject.c -rw-r--r-- 2.6 KB
init-mm.c -rw-r--r-- 1.6 KB
internal.h -rw-r--r-- 22.5 KB
interval_tree.c -rw-r--r-- 3.1 KB
io-mapping.c -rw-r--r-- 993 bytes
ioremap.c -rw-r--r-- 1.2 KB
khugepaged.c -rw-r--r-- 60.2 KB
kmemleak.c -rw-r--r-- 56.8 KB
ksm.c -rw-r--r-- 88.6 KB
list_lru.c -rw-r--r-- 13.8 KB
maccess.c -rw-r--r-- 9.1 KB
madvise.c -rw-r--r-- 36.2 KB
mapping_dirty_helpers.c -rw-r--r-- 10.5 KB
memblock.c -rw-r--r-- 60.6 KB
memcontrol.c -rw-r--r-- 191.9 KB
memfd.c -rw-r--r-- 8.2 KB
memory-failure.c -rw-r--r-- 60.7 KB
memory.c -rw-r--r-- 148.4 KB
memory_hotplug.c -rw-r--r-- 65.3 KB
mempolicy.c -rw-r--r-- 77.8 KB
mempool.c -rw-r--r-- 15.8 KB
memremap.c -rw-r--r-- 13.8 KB
memtest.c -rw-r--r-- 2.8 KB
migrate.c -rw-r--r-- 87.9 KB
mincore.c -rw-r--r-- 7.0 KB
mlock.c -rw-r--r-- 22.5 KB
mm_init.c -rw-r--r-- 5.3 KB
mmap.c -rw-r--r-- 102.0 KB
mmap_lock.c -rw-r--r-- 6.2 KB
mmu_gather.c -rw-r--r-- 8.6 KB
mmu_notifier.c -rw-r--r-- 35.0 KB
mmzone.c -rw-r--r-- 2.2 KB
mprotect.c -rw-r--r-- 17.7 KB
mremap.c -rw-r--r-- 28.3 KB
msync.c -rw-r--r-- 2.8 KB
nommu.c -rw-r--r-- 44.3 KB
oom_kill.c -rw-r--r-- 31.7 KB
page-writeback.c -rw-r--r-- 89.8 KB
page_alloc.c -rw-r--r-- 265.5 KB
page_counter.c -rw-r--r-- 6.7 KB
page_ext.c -rw-r--r-- 11.2 KB
page_idle.c -rw-r--r-- 5.2 KB
page_io.c -rw-r--r-- 11.2 KB
page_isolation.c -rw-r--r-- 9.1 KB
page_owner.c -rw-r--r-- 15.7 KB
page_poison.c -rw-r--r-- 2.5 KB
page_reporting.c -rw-r--r-- 10.3 KB
page_reporting.h -rw-r--r-- 1.6 KB
page_table_check.c -rw-r--r-- 6.4 KB
page_vma_mapped.c -rw-r--r-- 8.7 KB
pagewalk.c -rw-r--r-- 15.5 KB
percpu-internal.h -rw-r--r-- 7.0 KB
percpu-km.c -rw-r--r-- 3.2 KB
percpu-stats.c -rw-r--r-- 5.9 KB
percpu-vm.c -rw-r--r-- 11.7 KB
percpu.c -rw-r--r-- 102.5 KB
pgalloc-track.h -rw-r--r-- 1.3 KB
pgtable-generic.c -rw-r--r-- 5.6 KB
process_vm_access.c -rw-r--r-- 8.2 KB
ptdump.c -rw-r--r-- 4.0 KB
readahead.c -rw-r--r-- 19.6 KB
rmap.c -rw-r--r-- 69.1 KB
rodata_test.c -rw-r--r-- 1.3 KB
secretmem.c -rw-r--r-- 5.5 KB
shmem.c -rw-r--r-- 106.9 KB
shuffle.c -rw-r--r-- 4.7 KB
shuffle.h -rw-r--r-- 1.2 KB
slab.c -rw-r--r-- 105.7 KB
slab.h -rw-r--r-- 22.7 KB
slab_common.c -rw-r--r-- 32.9 KB
slob.c -rw-r--r-- 18.4 KB
slub.c -rw-r--r-- 153.6 KB
sparse-vmemmap.c -rw-r--r-- 15.7 KB
sparse.c -rw-r--r-- 26.0 KB
swap.c -rw-r--r-- 32.4 KB
swap_cgroup.c -rw-r--r-- 5.1 KB
swap_slots.c -rw-r--r-- 9.2 KB
swap_state.c -rw-r--r-- 24.0 KB
swapfile.c -rw-r--r-- 94.4 KB
truncate.c -rw-r--r-- 26.5 KB
usercopy.c -rw-r--r-- 9.6 KB
userfaultfd.c -rw-r--r-- 17.7 KB
util.c -rw-r--r-- 27.3 KB
vmacache.c -rw-r--r-- 2.7 KB
vmalloc.c -rw-r--r-- 103.1 KB
vmpressure.c -rw-r--r-- 13.9 KB
vmscan.c -rw-r--r-- 138.8 KB
vmstat.c -rw-r--r-- 54.6 KB
workingset.c -rw-r--r-- 21.7 KB
z3fold.c -rw-r--r-- 47.0 KB
zbud.c -rw-r--r-- 18.4 KB
zpool.c -rw-r--r-- 11.2 KB
zsmalloc.c -rw-r--r-- 57.3 KB
zswap.c -rw-r--r-- 38.9 KB

back to top