Revision 3cf6a32f3f2a45944dd5be5c6ac4deb46bcd3bee authored by Michael Petlan on 17 March 2022, 13:55:36 UTC, committed by Arnaldo Carvalho de Melo on 18 March 2022, 21:39:09 UTC
Before this patch, the symbol end address fixup to be called, needed two conditions being met: if (prev->end == prev->start && prev->end != curr->start) Where "prev->end == prev->start" means that prev is zero-long (and thus needs a fixup) and "prev->end != curr->start" means that fixup hasn't been applied yet However, this logic is incorrect in the following situation: *curr = {rb_node = {__rb_parent_color = 278218928, rb_right = 0x0, rb_left = 0x0}, start = 0xc000000000062354, end = 0xc000000000062354, namelen = 40, type = 2 '\002', binding = 0 '\000', idle = 0 '\000', ignore = 0 '\000', inlined = 0 '\000', arch_sym = 0 '\000', annotate2 = false, name = 0x1159739e "kprobe_optinsn_page\t[__builtin__kprobes]"} *prev = {rb_node = {__rb_parent_color = 278219041, rb_right = 0x109548b0, rb_left = 0x109547c0}, start = 0xc000000000062354, end = 0xc000000000062354, namelen = 12, type = 2 '\002', binding = 1 '\001', idle = 0 '\000', ignore = 0 '\000', inlined = 0 '\000', arch_sym = 0 '\000', annotate2 = false, name = 0x1095486e "optinsn_slot"} In this case, prev->start == prev->end == curr->start == curr->end, thus the condition above thinks that "we need a fixup due to zero length of prev symbol, but it has been probably done, since the prev->end == curr->start", which is wrong. After the patch, the execution path proceeds to arch__symbols__fixup_end function which fixes up the size of prev symbol by adding page_size to its end offset. Fixes: 3b01a413c196c910 ("perf symbols: Improve kallsyms symbol end addr calculation") Signed-off-by: Michael Petlan <mpetlan@redhat.com> Cc: Athira Jajeev <atrajeev@linux.vnet.ibm.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Kajol Jain <kjain@linux.ibm.com> Cc: Madhavan Srinivasan <maddy@linux.ibm.com> Link: http://lore.kernel.org/lkml/20220317135536.805-1-mpetlan@redhat.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 34e047a
File | Mode | Size |
---|---|---|
davinci | ||
drv-intf | ||
i2c | ||
tpg | ||
cec-notifier.h | -rw-r--r-- | 5.0 KB |
cec-pin.h | -rw-r--r-- | 2.8 KB |
cec.h | -rw-r--r-- | 15.3 KB |
demux.h | -rw-r--r-- | 22.7 KB |
dmxdev.h | -rw-r--r-- | 5.9 KB |
dvb-usb-ids.h | -rw-r--r-- | 18.2 KB |
dvb_ca_en50221.h | -rw-r--r-- | 4.4 KB |
dvb_demux.h | -rw-r--r-- | 10.8 KB |
dvb_frontend.h | -rw-r--r-- | 30.4 KB |
dvb_math.h | -rw-r--r-- | 1.8 KB |
dvb_net.h | -rw-r--r-- | 2.3 KB |
dvb_ringbuffer.h | -rw-r--r-- | 8.3 KB |
dvb_vb2.h | -rw-r--r-- | 7.7 KB |
dvbdev.h | -rw-r--r-- | 14.2 KB |
frame_vector.h | -rw-r--r-- | 1.4 KB |
hevc-ctrls.h | -rw-r--r-- | 9.2 KB |
imx.h | -rw-r--r-- | 190 bytes |
media-dev-allocator.h | -rw-r--r-- | 2.2 KB |
media-device.h | -rw-r--r-- | 17.0 KB |
media-devnode.h | -rw-r--r-- | 5.3 KB |
media-entity.h | -rw-r--r-- | 35.5 KB |
media-request.h | -rw-r--r-- | 12.0 KB |
rc-core.h | -rw-r--r-- | 12.2 KB |
rc-map.h | -rw-r--r-- | 14.4 KB |
rcar-fcp.h | -rw-r--r-- | 1.1 KB |
tuner-types.h | -rw-r--r-- | 7.5 KB |
tuner.h | -rw-r--r-- | 8.4 KB |
tveeprom.h | -rw-r--r-- | 3.3 KB |
v4l2-async.h | -rw-r--r-- | 10.7 KB |
v4l2-common.h | -rw-r--r-- | 18.7 KB |
v4l2-ctrls.h | -rw-r--r-- | 49.9 KB |
v4l2-dev.h | -rw-r--r-- | 16.5 KB |
v4l2-device.h | -rw-r--r-- | 18.5 KB |
v4l2-dv-timings.h | -rw-r--r-- | 9.1 KB |
v4l2-event.h | -rw-r--r-- | 6.0 KB |
v4l2-fh.h | -rw-r--r-- | 4.2 KB |
v4l2-flash-led-class.h | -rw-r--r-- | 5.8 KB |
v4l2-fwnode.h | -rw-r--r-- | 19.8 KB |
v4l2-h264.h | -rw-r--r-- | 2.9 KB |
v4l2-image-sizes.h | -rw-r--r-- | 827 bytes |
v4l2-ioctl.h | -rw-r--r-- | 33.3 KB |
v4l2-jpeg.h | -rw-r--r-- | 5.1 KB |
v4l2-mc.h | -rw-r--r-- | 7.5 KB |
v4l2-mediabus.h | -rw-r--r-- | 7.5 KB |
v4l2-mem2mem.h | -rw-r--r-- | 28.6 KB |
v4l2-rect.h | -rw-r--r-- | 5.7 KB |
v4l2-subdev.h | -rw-r--r-- | 44.7 KB |
v4l2-vp9.h | -rw-r--r-- | 8.3 KB |
videobuf-core.h | -rw-r--r-- | 6.8 KB |
videobuf-dma-contig.h | -rw-r--r-- | 909 bytes |
videobuf-dma-sg.h | -rw-r--r-- | 2.8 KB |
videobuf-vmalloc.h | -rw-r--r-- | 1.1 KB |
videobuf2-core.h | -rw-r--r-- | 48.8 KB |
videobuf2-dma-contig.h | -rw-r--r-- | 883 bytes |
videobuf2-dma-sg.h | -rw-r--r-- | 698 bytes |
videobuf2-dvb.h | -rw-r--r-- | 1.8 KB |
videobuf2-memops.h | -rw-r--r-- | 1.1 KB |
videobuf2-v4l2.h | -rw-r--r-- | 14.0 KB |
videobuf2-vmalloc.h | -rw-r--r-- | 509 bytes |
vsp1.h | -rw-r--r-- | 3.6 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...