Revision 3cf6a32f3f2a45944dd5be5c6ac4deb46bcd3bee authored by Michael Petlan on 17 March 2022, 13:55:36 UTC, committed by Arnaldo Carvalho de Melo on 18 March 2022, 21:39:09 UTC
Before this patch, the symbol end address fixup to be called, needed two
conditions being met:

  if (prev->end == prev->start && prev->end != curr->start)

Where
  "prev->end == prev->start" means that prev is zero-long
                             (and thus needs a fixup)
and
  "prev->end != curr->start" means that fixup hasn't been applied yet

However, this logic is incorrect in the following situation:

*curr  = {rb_node = {__rb_parent_color = 278218928,
  rb_right = 0x0, rb_left = 0x0},
  start = 0xc000000000062354,
  end = 0xc000000000062354, namelen = 40, type = 2 '\002',
  binding = 0 '\000', idle = 0 '\000', ignore = 0 '\000',
  inlined = 0 '\000', arch_sym = 0 '\000', annotate2 = false,
  name = 0x1159739e "kprobe_optinsn_page\t[__builtin__kprobes]"}

*prev = {rb_node = {__rb_parent_color = 278219041,
  rb_right = 0x109548b0, rb_left = 0x109547c0},
  start = 0xc000000000062354,
  end = 0xc000000000062354, namelen = 12, type = 2 '\002',
  binding = 1 '\001', idle = 0 '\000', ignore = 0 '\000',
  inlined = 0 '\000', arch_sym = 0 '\000', annotate2 = false,
  name = 0x1095486e "optinsn_slot"}

In this case, prev->start == prev->end == curr->start == curr->end,
thus the condition above thinks that "we need a fixup due to zero
length of prev symbol, but it has been probably done, since the
prev->end == curr->start", which is wrong.

After the patch, the execution path proceeds to arch__symbols__fixup_end
function which fixes up the size of prev symbol by adding page_size to
its end offset.

Fixes: 3b01a413c196c910 ("perf symbols: Improve kallsyms symbol end addr calculation")
Signed-off-by: Michael Petlan <mpetlan@redhat.com>
Cc: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: http://lore.kernel.org/lkml/20220317135536.805-1-mpetlan@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 34e047a
History
File Mode Size
Kconfig -rw-r--r-- 3.3 KB
Makefile -rw-r--r-- 1.1 KB
bat_algo.c -rw-r--r-- 5.2 KB
bat_algo.h -rw-r--r-- 713 bytes
bat_iv_ogm.c -rw-r--r-- 73.3 KB
bat_iv_ogm.h -rw-r--r-- 292 bytes
bat_v.c -rw-r--r-- 23.2 KB
bat_v.h -rw-r--r-- 816 bytes
bat_v_elp.c -rw-r--r-- 16.5 KB
bat_v_elp.h -rw-r--r-- 821 bytes
bat_v_ogm.c -rw-r--r-- 32.8 KB
bat_v_ogm.h -rw-r--r-- 914 bytes
bitarray.c -rw-r--r-- 2.6 KB
bitarray.h -rw-r--r-- 1.5 KB
bridge_loop_avoidance.c -rw-r--r-- 69.4 KB
bridge_loop_avoidance.h -rw-r--r-- 3.4 KB
distributed-arp-table.c -rw-r--r-- 50.4 KB
distributed-arp-table.h -rw-r--r-- 4.7 KB
fragmentation.c -rw-r--r-- 15.8 KB
fragmentation.h -rw-r--r-- 1.3 KB
gateway_client.c -rw-r--r-- 20.7 KB
gateway_client.h -rw-r--r-- 1.8 KB
gateway_common.c -rw-r--r-- 7.2 KB
gateway_common.h -rw-r--r-- 1.0 KB
hard-interface.c -rw-r--r-- 27.0 KB
hard-interface.h -rw-r--r-- 3.2 KB
hash.c -rw-r--r-- 1.7 KB
hash.h -rw-r--r-- 3.9 KB
log.c -rw-r--r-- 637 bytes
log.h -rw-r--r-- 4.0 KB
main.c -rw-r--r-- 19.9 KB
main.h -rw-r--r-- 12.1 KB
multicast.c -rw-r--r-- 68.6 KB
multicast.h -rw-r--r-- 2.8 KB
netlink.c -rw-r--r-- 41.2 KB
netlink.h -rw-r--r-- 944 bytes
network-coding.c -rw-r--r-- 55.5 KB
network-coding.h -rw-r--r-- 2.7 KB
originator.c -rw-r--r-- 36.6 KB
originator.h -rw-r--r-- 4.9 KB
routing.c -rw-r--r-- 36.3 KB
routing.h -rw-r--r-- 1.6 KB
send.c -rw-r--r-- 34.1 KB
send.h -rw-r--r-- 4.3 KB
soft-interface.c -rw-r--r-- 31.1 KB
soft-interface.h -rw-r--r-- 1.2 KB
tp_meter.c -rw-r--r-- 42.2 KB
tp_meter.h -rw-r--r-- 618 bytes
trace.c -rw-r--r-- 153 bytes
trace.h -rw-r--r-- 1.6 KB
translation-table.c -rw-r--r-- 125.8 KB
translation-table.h -rw-r--r-- 2.8 KB
tvlv.c -rw-r--r-- 18.7 KB
tvlv.h -rw-r--r-- 1.7 KB
types.h -rw-r--r-- 60.9 KB

back to top