Revision 3d8334def5cf831d2ed438aae021696a2faa4ddd authored by Oleg Nesterov on 29 October 2006, 15:57:16 UTC, committed by Linus Torvalds on 29 October 2006, 20:07:37 UTC
prepare_reply() adds GENL_HDRLEN to the payload (genlmsg_total_size()),
but then it does genlmsg_put()->nlmsg_put().  This means we forget to
reserve a room for 'struct nlmsghdr'.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Thomas Graf <tgraf@suug.ch>
Cc: Andrew Morton <akpm@osdl.org>
Cc: Shailabh Nagar <nagar@watson.ibm.com>
Cc: Balbir Singh <balbir@in.ibm.com>
Cc: Jay Lan <jlan@sgi.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent d46a3d0
Raw File
xt_comment.c
/*
 * Implements a dummy match to allow attaching comments to rules
 *
 * 2003-05-13 Brad Fisher (brad@info-link.net)
 */

#include <linux/module.h>
#include <linux/skbuff.h>
#include <linux/netfilter/x_tables.h>
#include <linux/netfilter/xt_comment.h>

MODULE_AUTHOR("Brad Fisher <brad@info-link.net>");
MODULE_DESCRIPTION("iptables comment match module");
MODULE_LICENSE("GPL");
MODULE_ALIAS("ipt_comment");
MODULE_ALIAS("ip6t_comment");

static int
match(const struct sk_buff *skb,
      const struct net_device *in,
      const struct net_device *out,
      const struct xt_match *match,
      const void *matchinfo,
      int offset,
      unsigned int protooff,
      int *hotdrop)
{
	/* We always match */
	return 1;
}

static struct xt_match xt_comment_match[] = {
	{
		.name		= "comment",
		.family		= AF_INET,
		.match		= match,
		.matchsize	= sizeof(struct xt_comment_info),
		.me		= THIS_MODULE
	},
	{
		.name		= "comment",
		.family		= AF_INET6,
		.match		= match,
		.matchsize	= sizeof(struct xt_comment_info),
		.me		= THIS_MODULE
	},
};

static int __init xt_comment_init(void)
{
	return xt_register_matches(xt_comment_match,
				   ARRAY_SIZE(xt_comment_match));
}

static void __exit xt_comment_fini(void)
{
	xt_unregister_matches(xt_comment_match, ARRAY_SIZE(xt_comment_match));
}

module_init(xt_comment_init);
module_exit(xt_comment_fini);
back to top