https://github.com/torvalds/linux
Revision 3e1bc8bf974e2d4e7beb842a4c801c2542eff3bd authored by Guillaume Nault on 13 June 2018, 13:09:20 UTC, committed by David S. Miller on 15 June 2018, 00:10:19 UTC
If 'fd' is negative, l2tp_tunnel_create() creates a tunnel socket using
the configuration passed in 'tcfg'. Currently, pppol2tp_connect() sets
the relevant fields to zero, tricking l2tp_tunnel_create() into setting
up an unusable kernel socket.

We can't set 'tcfg' with the required fields because there's no way to
get them from the current connect() parameters. So let's restrict
kernel sockets creation to the netlink API, which is the original use
case.

Fixes: 789a4a2c61d8 ("l2tp: Add support for static unmanaged L2TPv3 tunnels")
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 7ac6ab1
History
Tip revision: 3e1bc8bf974e2d4e7beb842a4c801c2542eff3bd authored by Guillaume Nault on 13 June 2018, 13:09:20 UTC
l2tp: prevent pppol2tp_connect() from creating kernel sockets
Tip revision: 3e1bc8b
File Mode Size
Documentation
LICENSES
arch
block
certs
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.clang-format -rw-r--r-- 12.8 KB
.cocciconfig -rw-r--r-- 59 bytes
.get_maintainer.ignore -rw-r--r-- 31 bytes
.gitattributes -rw-r--r-- 30 bytes
.gitignore -rw-r--r-- 1.5 KB
.mailmap -rw-r--r-- 9.3 KB
COPYING -rw-r--r-- 423 bytes
CREDITS -rw-r--r-- 96.3 KB
Kbuild -rw-r--r-- 2.2 KB
Kconfig -rw-r--r-- 321 bytes
MAINTAINERS -rw-r--r-- 447.9 KB
Makefile -rw-r--r-- 61.1 KB
README -rw-r--r-- 800 bytes

README

back to top