https://github.com/torvalds/linux
Revision 3e26c5feed2add218046ecf91bab3cfa9bf762a6 authored by Rafael J. Wysocki on 13 June 2019, 21:59:45 UTC, committed by Rafael J. Wysocki on 13 June 2019, 22:03:27 UTC
Commit d491f2b75237 ("PCI: PM: Avoid possible suspend-to-idle issue")
attempted to avoid a problem with devices whose drivers want them to
stay in D0 over suspend-to-idle and resume, but it did not go as far
as it should with that.
Namely, first of all, the power state of a PCI bridge with a
downstream device in D0 must be D0 (based on the PCI PM spec r1.2,
sec 6, table 6-1, if the bridge is not in D0, there can be no PCI
transactions on its secondary bus), but that is not actively enforced
during system-wide PM transitions, so use the skip_bus_pm flag
introduced by commit d491f2b75237 for that.
Second, the configuration of devices left in D0 (whatever the reason)
during suspend-to-idle need not be changed and attempting to put them
into D0 again by force is pointless, so explicitly avoid doing that.
Fixes: d491f2b75237 ("PCI: PM: Avoid possible suspend-to-idle issue")
Reported-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
1 parent d1fdb6d
Tip revision: 3e26c5feed2add218046ecf91bab3cfa9bf762a6 authored by Rafael J. Wysocki on 13 June 2019, 21:59:45 UTC
PCI: PM: Skip devices in D0 for suspend-to-idle
PCI: PM: Skip devices in D0 for suspend-to-idle
Tip revision: 3e26c5f
| File | Mode | Size |
|---|---|---|
| governors | ||
| Kconfig | -rw-r--r-- | 1.5 KB |
| Kconfig.arm | -rw-r--r-- | 2.5 KB |
| Kconfig.mips | -rw-r--r-- | 658 bytes |
| Kconfig.powerpc | -rw-r--r-- | 520 bytes |
| Makefile | -rw-r--r-- | 1.3 KB |
| coupled.c | -rw-r--r-- | 25.2 KB |
| cpuidle-arm.c | -rw-r--r-- | 3.9 KB |
| cpuidle-at91.c | -rw-r--r-- | 1.6 KB |
| cpuidle-big_little.c | -rw-r--r-- | 6.7 KB |
| cpuidle-calxeda.c | -rw-r--r-- | 1.6 KB |
| cpuidle-clps711x.c | -rw-r--r-- | 1.3 KB |
| cpuidle-cps.c | -rw-r--r-- | 4.2 KB |
| cpuidle-exynos.c | -rw-r--r-- | 3.4 KB |
| cpuidle-kirkwood.c | -rw-r--r-- | 2.3 KB |
| cpuidle-mvebu-v7.c | -rw-r--r-- | 3.3 KB |
| cpuidle-powernv.c | -rw-r--r-- | 10.6 KB |
| cpuidle-pseries.c | -rw-r--r-- | 6.7 KB |
| cpuidle-ux500.c | -rw-r--r-- | 3.2 KB |
| cpuidle-zynq.c | -rw-r--r-- | 1.5 KB |
| cpuidle.c | -rw-r--r-- | 17.5 KB |
| cpuidle.h | -rw-r--r-- | 2.1 KB |
| driver.c | -rw-r--r-- | 8.7 KB |
| dt_idle_states.c | -rw-r--r-- | 6.5 KB |
| dt_idle_states.h | -rw-r--r-- | 216 bytes |
| governor.c | -rw-r--r-- | 2.7 KB |
| poll_state.c | -rw-r--r-- | 1.4 KB |
| sysfs.c | -rw-r--r-- | 18.3 KB |
Computing file changes ...
