https://github.com/torvalds/linux
Revision 3e26c5feed2add218046ecf91bab3cfa9bf762a6 authored by Rafael J. Wysocki on 13 June 2019, 21:59:45 UTC, committed by Rafael J. Wysocki on 13 June 2019, 22:03:27 UTC
Commit d491f2b75237 ("PCI: PM: Avoid possible suspend-to-idle issue")
attempted to avoid a problem with devices whose drivers want them to
stay in D0 over suspend-to-idle and resume, but it did not go as far
as it should with that.
Namely, first of all, the power state of a PCI bridge with a
downstream device in D0 must be D0 (based on the PCI PM spec r1.2,
sec 6, table 6-1, if the bridge is not in D0, there can be no PCI
transactions on its secondary bus), but that is not actively enforced
during system-wide PM transitions, so use the skip_bus_pm flag
introduced by commit d491f2b75237 for that.
Second, the configuration of devices left in D0 (whatever the reason)
during suspend-to-idle need not be changed and attempting to put them
into D0 again by force is pointless, so explicitly avoid doing that.
Fixes: d491f2b75237 ("PCI: PM: Avoid possible suspend-to-idle issue")
Reported-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
1 parent d1fdb6d
Tip revision: 3e26c5feed2add218046ecf91bab3cfa9bf762a6 authored by Rafael J. Wysocki on 13 June 2019, 21:59:45 UTC
PCI: PM: Skip devices in D0 for suspend-to-idle
PCI: PM: Skip devices in D0 for suspend-to-idle
Tip revision: 3e26c5f
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 5.6 KB |
| Makefile | -rw-r--r-- | 1.1 KB |
| devres.c | -rw-r--r-- | 7.3 KB |
| extcon-adc-jack.c | -rw-r--r-- | 5.5 KB |
| extcon-arizona.c | -rw-r--r-- | 44.7 KB |
| extcon-axp288.c | -rw-r--r-- | 12.4 KB |
| extcon-gpio.c | -rw-r--r-- | 4.3 KB |
| extcon-intel-cht-wc.c | -rw-r--r-- | 12.6 KB |
| extcon-intel-int3496.c | -rw-r--r-- | 4.9 KB |
| extcon-intel-mrfld.c | -rw-r--r-- | 6.8 KB |
| extcon-intel.h | -rw-r--r-- | 384 bytes |
| extcon-max14577.c | -rw-r--r-- | 21.3 KB |
| extcon-max3355.c | -rw-r--r-- | 3.7 KB |
| extcon-max77693.c | -rw-r--r-- | 36.5 KB |
| extcon-max77843.c | -rw-r--r-- | 26.3 KB |
| extcon-max8997.c | -rw-r--r-- | 20.2 KB |
| extcon-palmas.c | -rw-r--r-- | 13.2 KB |
| extcon-ptn5150.c | -rw-r--r-- | 8.3 KB |
| extcon-qcom-spmi-misc.c | -rw-r--r-- | 3.9 KB |
| extcon-rt8973a.c | -rw-r--r-- | 18.8 KB |
| extcon-rt8973a.h | -rw-r--r-- | 7.9 KB |
| extcon-sm5502.c | -rw-r--r-- | 18.9 KB |
| extcon-sm5502.h | -rw-r--r-- | 10.6 KB |
| extcon-usb-gpio.c | -rw-r--r-- | 7.5 KB |
| extcon-usbc-cros-ec.c | -rw-r--r-- | 14.0 KB |
| extcon.c | -rw-r--r-- | 35.5 KB |
| extcon.h | -rw-r--r-- | 2.5 KB |
Computing file changes ...
