https://github.com/torvalds/linux
Revision 3e26c5feed2add218046ecf91bab3cfa9bf762a6 authored by Rafael J. Wysocki on 13 June 2019, 21:59:45 UTC, committed by Rafael J. Wysocki on 13 June 2019, 22:03:27 UTC
Commit d491f2b75237 ("PCI: PM: Avoid possible suspend-to-idle issue")
attempted to avoid a problem with devices whose drivers want them to
stay in D0 over suspend-to-idle and resume, but it did not go as far
as it should with that.
Namely, first of all, the power state of a PCI bridge with a
downstream device in D0 must be D0 (based on the PCI PM spec r1.2,
sec 6, table 6-1, if the bridge is not in D0, there can be no PCI
transactions on its secondary bus), but that is not actively enforced
during system-wide PM transitions, so use the skip_bus_pm flag
introduced by commit d491f2b75237 for that.
Second, the configuration of devices left in D0 (whatever the reason)
during suspend-to-idle need not be changed and attempting to put them
into D0 again by force is pointless, so explicitly avoid doing that.
Fixes: d491f2b75237 ("PCI: PM: Avoid possible suspend-to-idle issue")
Reported-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
1 parent d1fdb6d
Tip revision: 3e26c5feed2add218046ecf91bab3cfa9bf762a6 authored by Rafael J. Wysocki on 13 June 2019, 21:59:45 UTC
PCI: PM: Skip devices in D0 for suspend-to-idle
PCI: PM: Skip devices in D0 for suspend-to-idle
Tip revision: 3e26c5f
| File | Mode | Size |
|---|---|---|
| hisilicon | ||
| sti | ||
| tegra | ||
| Kconfig | -rw-r--r-- | 6.0 KB |
| Makefile | -rw-r--r-- | 1.3 KB |
| core.c | -rw-r--r-- | 24.2 KB |
| reset-a10sr.c | -rw-r--r-- | 3.2 KB |
| reset-ath79.c | -rw-r--r-- | 3.3 KB |
| reset-axs10x.c | -rw-r--r-- | 2.1 KB |
| reset-berlin.c | -rw-r--r-- | 2.5 KB |
| reset-brcmstb.c | -rw-r--r-- | 3.5 KB |
| reset-hsdk.c | -rw-r--r-- | 3.5 KB |
| reset-imx7.c | -rw-r--r-- | 10.0 KB |
| reset-lantiq.c | -rw-r--r-- | 5.3 KB |
| reset-lpc18xx.c | -rw-r--r-- | 5.9 KB |
| reset-meson-audio-arb.c | -rw-r--r-- | 4.0 KB |
| reset-meson.c | -rw-r--r-- | 5.4 KB |
| reset-oxnas.c | -rw-r--r-- | 2.7 KB |
| reset-pistachio.c | -rw-r--r-- | 3.3 KB |
| reset-qcom-aoss.c | -rw-r--r-- | 3.4 KB |
| reset-qcom-pdc.c | -rw-r--r-- | 3.2 KB |
| reset-simple.c | -rw-r--r-- | 4.8 KB |
| reset-simple.h | -rw-r--r-- | 1.3 KB |
| reset-socfpga.c | -rw-r--r-- | 2.0 KB |
| reset-stm32mp1.c | -rw-r--r-- | 2.8 KB |
| reset-sunxi.c | -rw-r--r-- | 1.9 KB |
| reset-ti-sci.c | -rw-r--r-- | 8.1 KB |
| reset-ti-syscon.c | -rw-r--r-- | 7.1 KB |
| reset-uniphier-glue.c | -rw-r--r-- | 4.7 KB |
| reset-uniphier.c | -rw-r--r-- | 14.0 KB |
| reset-zynq.c | -rw-r--r-- | 3.2 KB |
| reset-zynqmp.c | -rw-r--r-- | 2.8 KB |
Computing file changes ...
